Making sure wires are updated correctly when updating output of Explode #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BHoMBot check copyright-compliance |
|
@adecler to confirm, |
|
@BHoMBot check installer |
|
@adecler to confirm, |
FraserGreenroyd
deleted the
Grasshopper_Toolkit-#616-ExplodeOUtputWiresUpdateBug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #616
Another fix on the dynamic side of the explode component. When output were updated (i.e. kept but edited instead of removed or added), the wires would look fine until the component was moved (see details on issue).
This PR makes sure the wires are migrated correctly to the new outputs.
Test files
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/Grasshopper_Toolkit/%23616-OutputWireUpdateBug?csf=1&web=1&e=Cs26ln
Instructions are provided on the script:
