Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default values not assigned for Enumerables #611

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

adecler
Copy link
Member

@adecler adecler commented Feb 20, 2021

Issues addressed by this PR

Closes #528

Default values of Enumerable properties where not set correctly in Grasshopper. See issue for more details.

Test files

I used what was provided in the issue. Now working fine for me:

image

@adecler adecler added the type:bug Error or unexpected behaviour label Feb 20, 2021
@adecler adecler added this to the BHoM 4.1 β RC milestone Feb 20, 2021
@adecler adecler requested review from alelom and rolyhudson February 20, 2021 10:16
@adecler adecler self-assigned this Feb 20, 2021
@adecler
Copy link
Member Author

adecler commented Feb 20, 2021

@BHoMBot check copyright

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 20, 2021

@adecler to confirm, check-copyright-compliance task is now queued.

@adecler
Copy link
Member Author

adecler commented Feb 20, 2021

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 20, 2021

@adecler to confirm, check-installer task is now queued.

Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extremely useful! Thanks!

@adecler adecler merged commit ae4faa2 into master Feb 24, 2021
@adecler adecler deleted the Grasshopper_Toolkit-#528-PersistentDataBug branch February 24, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically generated Create() method does not assign default values for Reference type properties
2 participants