Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where Simplify and Reverse disappear after copy/save #603

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

adecler
Copy link
Member

@adecler adecler commented Feb 11, 2021

Issues addressed by this PR

Closes #588

Simplify and Reverse options of input/output parameters were still disappearing after copy/pasting or saving a component. This PR should fix that.

Test files

See #588 (comment)

@adecler adecler added the type:bug Error or unexpected behaviour label Feb 11, 2021
@adecler adecler added this to the BHoM 4.1 β RC milestone Feb 11, 2021
@adecler adecler requested a review from BingWangUS February 11, 2021 02:26
@adecler adecler self-assigned this Feb 11, 2021
Copy link

@BingWangUS BingWangUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@adecler
Copy link
Member Author

adecler commented Feb 11, 2021

@BHoMBot check copyright

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 11, 2021

@adecler to confirm, check-copyright-compliance task is now queued.

@adecler
Copy link
Member Author

adecler commented Feb 11, 2021

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 11, 2021

@adecler to confirm, check-installer task is now queued.

@adecler adecler merged commit 4f6ee76 into master Feb 11, 2021
@adecler adecler deleted the Grasshopper_Toolkit-#588-FixSimplifyAfterCopy branch February 11, 2021 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grasshopper_Toolkit: Simplify disappears in copy pasting components
2 participants