Fix duplicate components after unload & reload of GH #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelbaran
approved these changes
May 14, 2020
|
/azp run Grasshopper_Toolkit.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
BHoM/BHoM_UI#264
Issues addressed by this PR
Closes #504
Grasshopper effectively loads the BHoM plugin multiple times so a simple check on a static boolean doesn't work. Finding teh proper way to remove the event handler when GH was unloaded proved to be tricky so I decided to just ask the event handler to remove pre-existing handles of a specific type (has to be done via string since types are actually not equal between loaded instances)
Everything still works fine if you have multiple instances of GH, even if you unload/reload some of them.
Additional comments
I really really wanted to get my list of bugs down to zero 😋