Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excel_UI: Excelsheets with Datasets fail to open #365

Closed
IsakNaslundBh opened this issue Nov 4, 2022 · 2 comments · Fixed by #366
Closed

Excel_UI: Excelsheets with Datasets fail to open #365

IsakNaslundBh opened this issue Nov 4, 2022 · 2 comments · Fixed by #366
Assignees
Labels
type:bug Error or unexpected behaviour

Comments

@IsakNaslundBh
Copy link
Contributor

Description:

If a dataset is existing as a formula in excel sheets, it fails to open due to crashing on

if (!enumType.IsEnum)
with a null reference exception, due to datasets selected item being a string, not a type.

Steps to reproduce:

Add a dataset to an excel sheet. Save and open excel

Expected behaviour:

For load not to crash when a dataset is present somewhere in the sheet.

@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label Nov 4, 2022
@IsakNaslundBh IsakNaslundBh self-assigned this Nov 4, 2022
@FraserGreenroyd
Copy link
Contributor

@IsakNaslundBh is this the same as #338 ?

@IsakNaslundBh
Copy link
Contributor Author

No, do not think so. Think this was due to the fix added in #364 where DatasetCallers are passed to the UpdateEnum method, and then when SelectedItem is extracted a string is returned, not type, leading to a null reference exception on line 154 linked above.

Added double protection against it in the linked PR.

Not sure what #338 is about really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants