Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open and Non-planar curves treated as planar closed curves, with no warning or error #43

Closed
IsakNaslundBh opened this issue Sep 13, 2022 · 0 comments · Fixed by #44
Closed
Assignees
Labels
type:bug Error or unexpected behaviour

Comments

@IsakNaslundBh
Copy link
Contributor

Description:

Open planar curves runs with no errors and give non-sensical results, like:

image

non-planar curves also runs with no error and warnings, and gives results of a curve projected to a arbitrary plane with the normal och the average plane of the input curve. This should at least be warned for:

image

Steps to reproduce:

Use the Offset method with a open curve or a non-planar curve

Expected behaviour:

For Open curves to raise an error and return null

For non-planar curves to at least raise a warning.

Test file(s):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants