Base_Engine: Even log interference with analytics at startup

[IsakNaslundBh]

Description:

#2750 had an unforeseen impact on the behaviour on start-up for some edge cases. As the Eventlog is no longer Thread Static, this means that any events raised by the analytics will be captured in the same CurrentEvents log as the production code running. This can have an impact on opening scripts at the same time as the analytics is running.

Steps to reproduce:

An example of when this can become an issue is:

1. User switches to a branch that has added objects and or methods and runs a testing script with those objects/methods
2. Close the script, and switch to another branch without those objects/methods and rebuild
3. Open a script that uses BHoM, but do not have the named objects/methods in it.
4. Errors from failing to deserialise the objects/methods from the branch can appear on components that have nothing to do with those objects/methods:
   
5. Re-running the script makes all the errors disappear:
   

Expected behaviour:

For the Event log to be able to handle multiple threads in the production code, to allow notes/warnings and errors to be captured during parallel running of methods, but for other tasks running on the same process to not interfere with the log.

Test file(s):

[FraserGreenroyd]

Steps to reproduce:

An example of when this can become an issue is:

1. User switches to a branch that has added objects and or methods and runs a testing script with those objects/methods

This particular step suggests this isn't an issue for the standard users of the BHoM, only for developer users who I think would be ok with re-running scripts. So a slightly poor UX perhaps, but not for actual users of the BHoM, thus I think we could ignore this issue if it only happens during development of multiple branches?

[IsakNaslundBh]

Steps to reproduce:

An example of when this can become an issue is:

1. User switches to a branch that has added objects and or methods and runs a testing script with those objects/methods

This particular step suggests this isn't an issue for the standard users of the BHoM, only for developer users who I think would be ok with re-running scripts. So a slightly poor UX perhaps, but not for actual users of the BHoM, thus I think we could ignore this issue if it only happens during development of multiple branches?

In general I do not think this should be an issue for users just using installers, but mainly just for developers. I have not tested with edge test cases with installers though, such as:

1. Run (for example) 5.1 beta
2. Run a script with methods and objects added in 5.1
3. Downgrade BHoM (with installer) to 5.0 beta
4. Run any script.

Not sure if this would be an issue or not, but potentially, maybe could be. But even if it is, it is an edge case.

Depending on what you mean by ignore, I might agree with you, If you mean "lets not prioritise this right now" I agree. If you mean "lets close this issue and forget about it" I disagree 😄 .
But I do not think any urgent action is required, more one good to be aware of in case it happens and for the core team to be aware of, also in case it happens to a newer developer for us to be able to give guidance 😄