Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base_Engine: The set geometry method in BHoM_Engine does not do anything #1754

Closed
IsakNaslundBh opened this issue May 8, 2020 · 1 comment · Fixed by #3148
Closed

Base_Engine: The set geometry method in BHoM_Engine does not do anything #1754

IsakNaslundBh opened this issue May 8, 2020 · 1 comment · Fixed by #3148
Assignees
Labels
type:bug Error or unexpected behaviour

Comments

@IsakNaslundBh
Copy link
Contributor

IsakNaslundBh commented May 8, 2020

Description:

The method does a dynamic cast call to an method that returns the obejcts. Should either be fixed or removed as it currently is confusing rather than adding value

Steps to reproduce:

Try using the SetGeometry method in the base BHoM_Engine.

Expected behaviour:

For it to either work or not exist.

Test file(s):

@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label May 8, 2020
@adecler adecler changed the title BHoM_Engine: The set geometry method in BHoM_Engine does not do anything Base_Engine: The set geometry method in BHoM_Engine does not do anything Nov 24, 2020
@FraserGreenroyd FraserGreenroyd self-assigned this Jan 8, 2023
@FraserGreenroyd
Copy link
Contributor

I'm voting to go with removing if no one has any objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants