You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ideally, diffing should account for differences in the Fragments.
However, this is now not possible due to the fact we are storing the Hash in a HashFragment.
Adding a check for the Fragment type in the Diffing algorithm would be highly inefficient (potentially also not feasible if the referenced Kellerman library does not allow for that).
Proposed solution
Given the fact that we are ignoring CustomData (which is probably more correct, given that we are saving only "temporary" data in there, like Adapter ids), the Hash might be better stored in CustomData.
The text was updated successfully, but these errors were encountered:
alelom
changed the title
Diffing_Engine: diffing not to ignore the Fragments
Diffing_Engine: include the Fragments in the diffing comparison
Nov 4, 2019
Description:
Ideally, diffing should account for differences in the Fragments.
However, this is now not possible due to the fact we are storing the Hash in a HashFragment.
Adding a check for the Fragment type in the Diffing algorithm would be highly inefficient (potentially also not feasible if the referenced Kellerman library does not allow for that).
Proposed solution
Given the fact that we are ignoring CustomData (which is probably more correct, given that we are saving only "temporary" data in there, like Adapter ids), the Hash might be better stored in CustomData.
The text was updated successfully, but these errors were encountered: