Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diffing_Engine: include the Fragments in the diffing comparison #1294

Closed
alelom opened this issue Nov 4, 2019 · 1 comment
Closed

Diffing_Engine: include the Fragments in the diffing comparison #1294

alelom opened this issue Nov 4, 2019 · 1 comment
Assignees
Labels
type:feature New capability or enhancement

Comments

@alelom
Copy link
Member

alelom commented Nov 4, 2019

Description:

Ideally, diffing should account for differences in the Fragments.
However, this is now not possible due to the fact we are storing the Hash in a HashFragment.

Adding a check for the Fragment type in the Diffing algorithm would be highly inefficient (potentially also not feasible if the referenced Kellerman library does not allow for that).

Proposed solution

Given the fact that we are ignoring CustomData (which is probably more correct, given that we are saving only "temporary" data in there, like Adapter ids), the Hash might be better stored in CustomData.

@alelom alelom added the type:feature New capability or enhancement label Nov 4, 2019
@alelom alelom self-assigned this Nov 4, 2019
@alelom alelom changed the title Diffing_Engine: diffing not to ignore the Fragments Diffing_Engine: include the Fragments in the diffing comparison Nov 4, 2019
@alelom
Copy link
Member Author

alelom commented Mar 3, 2022

Closed by #1900

@alelom alelom closed this as completed Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant