From 9275ddcfa764bafe456ddd62096fcb6375092c8d Mon Sep 17 00:00:00 2001 From: Isak Naslund Date: Tue, 8 Sep 2020 15:45:25 +0200 Subject: [PATCH] Review comments --- Structure_Engine/Query/PointGrid.cs | 7 ++++--- Structure_Engine/Query/Visualize.cs | 8 ++------ 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/Structure_Engine/Query/PointGrid.cs b/Structure_Engine/Query/PointGrid.cs index 8af3febfd..36a88d603 100644 --- a/Structure_Engine/Query/PointGrid.cs +++ b/Structure_Engine/Query/PointGrid.cs @@ -123,9 +123,10 @@ public static List> PointGrid(this FEMesh mesh) return mesh.Faces.Select(x => x.PointGrid(mesh)).ToList(); } - [Description("Generates a rectangular grid of points on the each face of the FEMesh. Used for load visualisation.")] - [Input("mesh", "The FEMesh to generate a grid on.")] - [Output("grid", "Rectangular grid of points on the FEMesh.")] + [Description("Generates a rectangular grid of points on the FEMeshFace of the FEMesh. Used for load visualisation.")] + [Input("face", "The FEMeshFace to generate a grid on.")] + [Input("mesh", "The FEMesh to which the face belongs.")] + [Output("grid", "Rectangular grid of points on the FEMeshFace.")] public static List PointGrid(this FEMeshFace face, FEMesh mesh) { List pts = face.NodeListIndices.Select(i => mesh.Nodes[i].Position).ToList(); diff --git a/Structure_Engine/Query/Visualize.cs b/Structure_Engine/Query/Visualize.cs index 339b72e7e..c882b54f9 100644 --- a/Structure_Engine/Query/Visualize.cs +++ b/Structure_Engine/Query/Visualize.cs @@ -58,7 +58,6 @@ public static List Visualize(this AreaTemperatureLoad areaTempLoad, doub foreach (IAreaElement element in areaTempLoad.Objects.Elements) { - List> allEdges = edgeDisplay ? ISubElementBoundaries(element) : new List>(); List allOrientations = IAllLocalOrientations(element); List> subElementGrids = gridDisplay ? ISubElementPointGrids(element) : new List>(); @@ -106,7 +105,6 @@ public static List Visualize(this AreaUniformlyDistributedLoad areaUDL, for (int i = 0; i < allOrientations.Count; i++) { - IEnumerable edges = edgeDisplay ? allEdges[i] : null; List pts = gridDisplay ? subElementGrids[i] : null; Basis orientation = allOrientations[i]; @@ -481,7 +479,7 @@ public static List Visualize(this PointVelocity pointVelocity, double sc /***************************************************/ [Description("Draws arrows representing the load along the edges of the contour of the load.")] - [Input("pointVelocity", "The node load to visualise.")] + [Input("contourLoad", "The ContourLoad to visualise.")] [Input("scaleFactor", "Scales the arrows drawn. Default scaling of 1 means 1 m/s per metre.")] [Input("displayForces", "Toggles whether forces should be displayed or not.")] [Input("displayMoments", "Toggles whether moments should be displayed or not. Unused for contour loads.")] @@ -520,14 +518,13 @@ public static List Visualize(this ContourLoad contourLoad, double scaleF arrows.AddRange(ConnectedArrows(contourLoad.Contour.SubParts(), forceVec, asResultants, orientation, 1, true)); - return arrows; } /***************************************************/ [Description("Draws arrows representing the load along the length of the line of the load.")] - [Input("pointVelocity", "The node load to visualise.")] + [Input("lineLoad", "The GeometricalLineLoad to visualise.")] [Input("scaleFactor", "Scales the arrows drawn. Default scaling of 1 means 1 m/s per metre.")] [Input("displayForces", "Toggles whether forces should be displayed or not.")] [Input("displayMoments", "Toggles whether moments should be displayed or not. Unused for contour loads.")] @@ -594,7 +591,6 @@ public static List Visualize(this GeometricalLineLoad lineLoad, double s } - return arrows; }