Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added glulam and sawn Timber datasets #141

Merged
merged 2 commits into from
May 15, 2023
Merged

Added glulam and sawn Timber datasets #141

merged 2 commits into from
May 15, 2023

Conversation

kaichelliah
Copy link
Contributor

Generated and added glulam and sawn timber datasets

NOTE: Depends on

BHoM/BHoM#1469

Issues addressed by this PR

#95
close #95
close #114

Material Property datasets for sawn timber and glulam have been provided based of Eurocode sourced datasets.

Test files

Changelog

Additional comments

New issue to be opened will be to adapt or re-create the current timberRectangularSection Methods to accomodate the sawntimber/glulam material fragments.

@kaichelliah
Added glulam and sawn Timber datasets
cf09727 
Generated and added glulam and sawn timber datasets
@kaichelliah kaichelliah added size:S Measured in minutes priority:high High impact, high user value, driven by live project needs labels May 11, 2023
@kaichelliah kaichelliah requested a review from IsakNaslundBh May 11, 2023 09:29
@kaichelliah kaichelliah self-assigned this May 11, 2023
@kaichelliah kaichelliah mentioned this pull request May 11, 2023
Closed
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented May 11, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check dataset-compliance

There are 2 requests in the queue ahead of you.

FraserGreenroyd
FraserGreenroyd previously requested changes May 11, 2023
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request requires suitable labels for the change log before merge.

@kaichelliah kaichelliah added the type:feature New capability or enhancement label May 11, 2023
IsakNaslundBh
IsakNaslundBh requested changes May 11, 2023
View reviewed changes
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The glulam dataset is missing Source. Please make sure it is attached to the dataset as it is for the SawnTimber

@kaichelliah
Copy link
Contributor Author

@IsakNaslundBh Thanks for that I've updated the source and committed. Have you seen my issue: BHoM/BHoM#1518
I hard to really test these datasets in use properly in a workflow other than doing value checks until we sort this out. Happy to push LVL next week and maybe have a look at fixing this issue if your ok with that?

IsakNaslundBh
IsakNaslundBh approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have cross checked all values against values in referenced tables, and all correct.

Happy to approve, good work!

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented May 15, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check project-compliance

There are 40 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh dismissed FraserGreenroyd’s stale review May 15, 2023 09:58

Dismissing as label added to PR

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented May 15, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check dataset-compliance

There are 2 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented May 15, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check dataset-compliance

There are 1 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented May 15, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check dataset-compliance

There are 1 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented May 15, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check dataset-compliance

There are 1 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented May 15, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check dataset-compliance

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented May 15, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check dataset-compliance

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented May 15, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented May 15, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is ready-to-merge.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 13482309946

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 13482309946

@bhombot-ci
Copy link

bhombot-ci bot commented May 15, 2023

@FraserGreenroyd I have now provided a passing check on reference 13482309946 as requested.

@IsakNaslundBh IsakNaslundBh merged commit 1c69db1 into develop May 15, 2023
@IsakNaslundBh IsakNaslundBh deleted the BHoM_Datasets-#95-AddSawnTImberAndGlulamMaterials branch May 15, 2023 11:11
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsakNaslundBh IsakNaslundBh IsakNaslundBh approved these changes

@FraserGreenroyd FraserGreenroyd Awaiting requested review from FraserGreenroyd

Assignees

@kaichelliah kaichelliah

Labels
priority:high High impact, high user value, driven by live project needs size:S Measured in minutes type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BHoM_Datasets: aluminium & timber materials welcome. Add timber material properties from EC1995
3 participants
@kaichelliah @FraserGreenroyd @IsakNaslundBh