GCC 14 emits extra warnings

[Vekhir]

Hi,
when linking a BSV project using bsc and Bluesim with GCC 14.1, the following warning occurs in several places:

In file included from /opt/bluespec/lib/Bluesim/bluesim_primitives.h:6,
                 from ./model_mkFibOne.cxx:7:
/opt/bluespec/lib/Bluesim/bs_prim_mod_reg.h:22:14: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
   22 |   MOD_Reg<T>(tSimStateHdl simHdl, const char* name, Module* parent,
      |              ^~~~~~~~~~~~
/opt/bluespec/lib/Bluesim/bs_prim_mod_reg.h:22:14: note: remove the ‘< >’

Description

BDW provides for development two modes for compilation/simulation: Bluesim and Verilog. The Verilog mode works fine, the Bluesim mode however emits above warnings (and produces a binary which doesn't run, but that's a separate issue).

Steps to reproduce

1. Copy examples/smoke_test/FibOne.bsv into a local directory.
2. Run bsc -u -sim -simdir . -bdir . -info-dir . -keep-fires -p %/Libraries -g mkFibOne FibOne.bsv
3. Run bsc -e mkFibOne -sim -o ./out -simdir . -p %/Libraries -bdir . -keep-fires

These warnings also lead to test failures when running make check whereever the output is tested. Afaict, the failing tests are all affected by this mismatch.
They also show this warning:

Bluesim object created: model_mkTbGCD.{h,o}
../../../../src/bluesim/event_queue.cxx:8:24: warning: ‘bk_clock_name’ violates the C++ One Definition Rule [-Wodr]
    8 | extern "C" const char* bk_clock_name(tClock handle);
      |                        ^
../../../../src/bluesim/kernel.cxx:1093:13: note: type mismatch in parameter 1
 1093 | const char* bk_clock_name(tSimStateHdl simHdl, tClock clk)
      |             ^
../../../../src/bluesim/kernel.cxx:1093:13: note: type ‘struct tSimState *’ should match type ‘tClock’
../../../../src/bluesim/kernel.cxx:1093:13: note: ‘bk_clock_name’ was previously declared here
../../../../src/bluesim/kernel.cxx:1093:13: note: code may be misoptimized unless ‘-fno-strict-aliasing’ is used

System information

• OS: Arch Linux
• Kernel: Linux 6.8.9-arch1-2
• bsc: c481d7f (main, via bluespec-git)
• GCC: 14.1.1+r1+g43b730b9134-1
• GHC: 9.2.8-1
• bdw: B-Lang-org/bdw@0f8ffcb (main, via bluespec-bdw-git)

Full logs

warnings.log
tests.log

[quark17]

Thank you for reporting this! PR #701 (that has just been merged) should fix the template-id warnings, that you mention first. I will also file a PR for the second warning.