Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return valid IdentifierName for declarations with placeholder text for symbolic name #2491

Closed
bhsubra opened this issue May 3, 2021 · 1 comment

Comments

@bhsubra
Copy link
Contributor

bhsubra commented May 3, 2021

Snippet templates available here: https://github.com/Azure/bicep/tree/main/src/Bicep.LangServer/Snippets/Templates have placeholder text for symbolic name. We seem to return <error> as IdentiferName while parsing. We should be returning placeholder text instead. Consider below example:
resource ${1:dnsZone} 'Microsoft.Network/dnsZones@2018-05-01' = {
name: ${2:'name'}
location: 'global'
}

We should return ${1:dnsZone} as IdentifierName in this case

@alex-frankel
Copy link
Collaborator

Closing - we decided not to fix this

@ghost ghost locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants