Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode completions not working for Azure Monitor #1703

Closed
satyavel opened this issue Mar 3, 2021 · 1 comment
Closed

VSCode completions not working for Azure Monitor #1703

satyavel opened this issue Mar 3, 2021 · 1 comment
Labels
Needs: Author Feedback Awaiting feedback from the author of the issue

Comments

@satyavel
Copy link
Collaborator

satyavel commented Mar 3, 2021

Opening per Marcin's suggestion. Investigate which Azure Monitor types maybe missing Schemas. The types tab-complete in Bicep. Link to REDDIT thread: https://www.reddit.com/r/AZURE/comments/lbk9rj/arm_templates_v_20_aka_project_bicep/gnbzunm?utm_source=share&utm_medium=web2x&context=3

@alex-frankel
Copy link
Collaborator

Closing. Anthony added more context here, but it works well in bicep using the scope property. Here is his response:


Keep all the great feedback coming! I wanted to address the point about missing types for Microsoft.Insights/diagnosticSettings first, and will follow back later on the other points you have raised.

None of the myriad diagnostic settings types have schemas (and hence tab-complete or validation). E.g.: "Microsoft.Web/sites/providers/diagnosticSettings".

Microsoft.Insights/diagnosticSettings is an unusual case - it's being used here as an extension resource on a resource of type Microsoft.Web/sites. We added support for the support "scope" for a simpler and more idiomatic way to deploy extension resources in an ARM template (see this document for the syntax). We actually have schemas available for Microsoft.Insights/diagnosticSettings and other extension resource types, but they aren't being included in the selection list, which is why this doesn't work today. I have created Azure/azure-resource-manager-schemas#1547 to track a fix for that.

Note that Bicep does already understand the concept of scope, so we do have type information available for Microsoft.Insights/diagnosticSettings - see docs/examples/201/log-analytics-with-solutions-and-diagnostics/main.bicep for an example.

--

And here is the schema issue: Azure/azure-resource-manager-schemas#1547

@ghost ghost locked as resolved and limited conversation to collaborators May 28, 2023
@StephenWeatherford StephenWeatherford added Needs: Author Feedback Awaiting feedback from the author of the issue and removed awaiting response labels Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Needs: Author Feedback Awaiting feedback from the author of the issue
Projects
None yet
Development

No branches or pull requests

4 participants