Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brm validate does not detect indirect module tests #133

Closed
Gordonby opened this issue Aug 4, 2022 · 2 comments · Fixed by Azure/bicep#8191
Closed

brm validate does not detect indirect module tests #133

Gordonby opened this issue Aug 4, 2022 · 2 comments · Fixed by Azure/bicep#8191
Assignees

Comments

@Gordonby
Copy link
Contributor

Gordonby commented Aug 4, 2022

I'm authoring some complex tests for a new module. I've therefore split the tests out into their own files, and referenced them from main.test.bicep

However this does seem to cause the brm validate an issue

dapr-containerapps-environment\test\main.test.bicep" is invalid. Could not find tests in the file. Please make sure to add at least one module referencing the main Bicep file.

image

@ghost ghost added the Needs: Triage 🔍 Maintainers need to triage still label Aug 4, 2022
@shenglol shenglol added Enhancement and removed Needs: Triage 🔍 Maintainers need to triage still labels Aug 5, 2022
@shenglol
Copy link
Contributor

shenglol commented Aug 5, 2022

Do you think if this still needed if we add the support for running multiple test files?

@Gordonby
Copy link
Contributor Author

Gordonby commented Aug 5, 2022

Do you think if this still needed if we add the support for running multiple test files?

Nope, that'd do it.

@shenglol shenglol added this to Bicep Aug 21, 2022
@shenglol shenglol moved this to Todo in Bicep Aug 21, 2022
@shenglol shenglol moved this from Todo to In Progress in Bicep Aug 21, 2022
@anthony-c-martin anthony-c-martin moved this from In Progress to In Review in Bicep Aug 30, 2022
Repository owner moved this from In Review to Done in Bicep Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants