Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG#31069208: Fixed Prefix filtering from File Path #1618

Merged
merged 13 commits into from
Feb 3, 2025

Conversation

jainakanksha-msft
Copy link
Collaborator

@jainakanksha-msft jainakanksha-msft commented Jan 27, 2025

✅ What

This update addresses a bug related to subdirectory separation in file paths.

🤔 Why

A customer reported an issue where mounting blobfuse with the subdirectory option caused failures in opening certain files. Upon investigation, we discovered that files named identically to directories failed to open.

👩‍🔬 How to validate if applicable

Before change

  1. In your storage account create a folder abc
  2. Create File abc.txt
  3. "./blobfuse2 mount --subdirectory=abc"
  4. ls abc.txt
  5. It is failing saying that "abc.txt: No such file or directory"

After Change

  1. "./blobfuse2 mount --subdirectory=abc"
  2. ls abc.txt
  3. It will result with proper ls output.

🔖 Related links

@vibhansa-msft vibhansa-msft added this to the v2-2.4.1 milestone Jan 27, 2025
@vibhansa-msft vibhansa-msft linked an issue Jan 27, 2025 that may be closed by this pull request
@jainakanksha-msft jainakanksha-msft changed the title BUG#31069208: Fixed Prefix filtering from folder BUG#31069208: Fixed Prefix filtering from File Path Jan 27, 2025
@jainakanksha-msft jainakanksha-msft merged commit bc4f528 into blobfuse/2.4.1 Feb 3, 2025
8 checks passed
@jainakanksha-msft jainakanksha-msft deleted the bugFixFileFolder branch February 3, 2025 09:01
vibhansa-msft added a commit that referenced this pull request Feb 3, 2025
* feat: support workload identity token (#1556)

* feat: support workload identity token

* Create block pool only once in child process (#1581)

* create block pool in child only

* Update golang.org/x/crypto to v0.31.0 (#1594)

* Update golang.org/x/crypto to v0.31.0

* sync with main (#1603)

* updated year in copyright message (#1601)

* Use ListBlob for hns accounts  (#1555)

* Optimize HNS listing

* Added statfs for block-cache (#1470)

* Added statfs for block_cache

* Add strong consistency check for data on disk (#1604)

* Add strong consistency check for data on disk

* bug in block cache open call (#1580)

* current implementation of open file when opened in O_WRONLY will truncate the file to zero. This is incorrect behaviour.
We don't see it in the normal scenario as write-back cache is on by default. Hence all the open calls with O_WRONLY will be redirected O_RDWR.
To simulate this turn of the write-back cache and then open file in O_WRONLY.

* Feature: Blob filter (#1595)

* Integrating blob filter in azstorage

* Serve getAttr call for destination file after the Copy finishes from the cache

* Cleanup on start shall be set to cleanup temp cache (#1613)

* Add Tests

* Refactor the code and refresh the cache after copying the attributes

* Automate blobfuse2 setup for new VM (#1575)

added script for blobfuse setup and azsecpack setup in VM

* * Update the Unit tests.
* Refactor the Code

* Update Changelog

* do go fmt on src

* Downgrade go version to 1.22.7 due to memory issues in 1.23 (#1619)

* Enable ETAG based validation on every block download to provide higher consistency (#1608)

* Make etag validation a defualt option

* BUG#31069208:  Fixed Prefix filtering from File Path (#1618)

* Fixed the logic to filter out folder prefix from path
* Added/Updated/Removed test case

---------

Co-authored-by: weizhi <[email protected]>
Co-authored-by: Sourav Gupta <[email protected]>
Co-authored-by: Jan Jagusch <[email protected]>
Co-authored-by: ashruti-msft <[email protected]>
Co-authored-by: syeleti-msft <[email protected]>
Co-authored-by: jainakanksha-msft <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File open error for storage mounted with subdirectory and block cache.
4 participants