Adding support for Microsoft.Web sites/sourcecontrols #4491
Conversation
nishant221
requested review from
davefellows,
theunrepentantgeek,
matthchr,
babbageclunk and
super-harsh
as code owners
| │ │ │ └── RuntimeVersion: *string | ||
| │ │ ├── ContainerConfiguration: *Object (4 properties) | ||
| │ │ │ ├── ImageName: *string | ||
| │ │ │ ├── Password: *genruntime.SecretReference |
|
/ok-to-test sha=cbf55fc |
|
@theunrepentantgeek I have renamed the file as requested. Can you please have a relook. Thanks. |
|
@theunrepentantgeek Gentle reminder : ) Can you please have a look and see if this can be merged. |
|
/ok-to-test sha=3a05eb5 |
|
Looking good. I've triggered our CI pipeline to run. |
|
CI builds are failing during replay of the test Typically, these are easy to resolve. In most cases re-recording the test is sufficient. Sometimes, these failures indicate a need to implement a resource extension to customize the reconciliation. I'll investigate to see if that's necessary, but in the meantime, it would be worth deleting the existing recording and re-recording the test with TEST_FILTER=Test_Web_SitesSourcecontrol_CRUD TIMEOUT=60m task controller:test-integration-envtestOnce re-recorded, run the test again to ensure the recording does playback properly. |
nishant221
force-pushed
the
srcctrl-support
branch
from
2bda8a7 to
b4df8fb
Compare
|
@theunrepentantgeek I have re-recorded the test and re-ran it locally. It is showing as passed. Below screenshot for reference. Kindly take a look. 
|
|
Thanks for the update; I'll trigger our CI runs now. |
|
I pulled your branch and ran that test locally with TEST_FILTER=Test_Web_SitesSourcecontrol_CRUD TIMEOUT=60m task controller:test-integration-envtestTest output included which looks really good. CI is now running, hopefully it will return the same verdict. |
|
/ok-to-test sha=b4df8fb |
|
Thanks @nishant221, much appreciated. |
Closes #4490
What this PR does
Add Support for Microsoft.Web sites/sourcecontrols
How does this PR make you feel? Excited :)
Checklist