Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for when submodule references are stale #2091

Closed
theunrepentantgeek opened this issue Feb 14, 2022 · 3 comments
Closed
Assignees
Milestone

Comments

@theunrepentantgeek
Copy link
Member

Describe the current behavior

A common error is to fail to update our git submodules after doing a pull, which can result in the local working folder being stale. This in turn can result in errors like this one when the generator is run:

E0211 14:19:54.561995   27841 gen_kustomize.go:111] Error during code generation:
failed during pipeline stage 23/57: 
Verify there are no ErroredType's containing errors: 
"github.com/Azure/azure-service-operator/v2/api/network/v1alpha1api20180901/PrivateDnsZone" has property "Status" with errors:
"missing status information for github.com/Azure/azure-service-operator/v2/api/network/v1alpha1api20180901/PrivateDnsZones"

(Message has been formatted for readability.)

Even if this particular message isn't caused by stale submodule references, this has happened frequently in the past.

Describe the improvement

We need to improve our documentation so that someone searching our repo for this error can find guidance.

@matthchr
Copy link
Member

@Porges is working on #2084 which might end up changing the format of this particular error (and also changes what submodules we even need). So it might make sense to do this after that merges.

@theunrepentantgeek theunrepentantgeek self-assigned this May 30, 2022
@theunrepentantgeek
Copy link
Member Author

We should still do this.

@matthchr
Copy link
Member

matthchr commented Oct 3, 2022

Probably should still do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants