Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore volatile properties when deciding whether to reconcile a resource #2026

Open
theunrepentantgeek opened this issue Jan 10, 2022 · 7 comments

Comments

@theunrepentantgeek
Copy link
Member

theunrepentantgeek commented Jan 10, 2022

We're planning on comparing the resource-as-defined with the resouce-as-read-from-ARM and doing a reconciliation between the two (First steps towards this are PR #2022 and Issue #1491).

As already discussed, we're expecting some false positives due to properties that are service defined and likely to change regularly.

We should look to use the proposed x-ms-volatile property from the Swagger specs to eliminate these properties from consideration.

x-ms-volatile
Mark if a property is a system metric or prone to changes without user interaction
Examples of applicable properties
o nodeUpTimeInSeconds
o lastAccessedTime
o quotaNextResetTime

@matthchr
Copy link
Member

Related to #1491

@matthchr
Copy link
Member

Until we have #1491 we don't actually have to do this, so makes sense to defer this until #1491.

@matthchr
Copy link
Member

No change on the above comment

@theunrepentantgeek
Copy link
Member Author

Ideally, a solution to this would also allow us to support #2938 - the only difference is the source of the request to ignore the property.

@matthchr
Copy link
Member

matthchr commented Nov 7, 2023

This ties in with diffing, but is not currently needed so not worrying about this quite yet.

@theunrepentantgeek theunrepentantgeek modified the milestones: v2.6.0, v2.7.0 Dec 11, 2023
@matthchr matthchr removed this from the v2.7.0 milestone Feb 22, 2024
@matthchr matthchr added the low-priority Low priority item. We'll get to it eventually. label Feb 22, 2024
@matthchr matthchr removed the low-priority Low priority item. We'll get to it eventually. label Aug 5, 2024
@matthchr
Copy link
Member

matthchr commented Aug 5, 2024

No change from above.

@matthchr
Copy link
Member

No change from the above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants