-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better heuristic needed for property comments #1768
Comments
This might actually be improved by #2084. |
Lets revisit this after we merge the Swagger PRs |
We need to double-check if we still need this issue. |
Still need to double check |
In practice it seems that this is working well for us. Going to close this. If there is a user complaint about this we can revisit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the current behavior
As of PR #1767, we select between multiple candidate property comments by selecting the longer one, assuming that it will be more specific (less generic).
This isn't an ideal solution, as it may sometimes choose a comment from a mixin instead of the one specified on the resource definition.
Describe the improvement
@Porges suggests that we should do the selection based on depth of the type in the recursive tree being walked.
Additional context
See also #1657 for the original bug report.
The text was updated successfully, but these errors were encountered: