Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better heuristic needed for property comments #1768

Closed
theunrepentantgeek opened this issue Sep 1, 2021 · 5 comments
Closed

Better heuristic needed for property comments #1768

theunrepentantgeek opened this issue Sep 1, 2021 · 5 comments
Assignees

Comments

@theunrepentantgeek
Copy link
Member

Describe the current behavior

As of PR #1767, we select between multiple candidate property comments by selecting the longer one, assuming that it will be more specific (less generic).

This isn't an ideal solution, as it may sometimes choose a comment from a mixin instead of the one specified on the resource definition.

Describe the improvement

@Porges suggests that we should do the selection based on depth of the type in the recursive tree being walked.

Additional context

See also #1657 for the original bug report.

@matthchr
Copy link
Member

matthchr commented Apr 4, 2022

This might actually be improved by #2084.

@matthchr
Copy link
Member

matthchr commented Aug 8, 2022

Lets revisit this after we merge the Swagger PRs

@matthchr
Copy link
Member

matthchr commented Feb 7, 2023

We need to double-check if we still need this issue.

@theunrepentantgeek
Copy link
Member Author

Still need to double check

@matthchr
Copy link
Member

matthchr commented Nov 7, 2023

In practice it seems that this is working well for us. Going to close this. If there is a user complaint about this we can revisit.

@matthchr matthchr closed this as completed Nov 7, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Recently Completed in Azure Service Operator Roadmap Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants