Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all resources implement ResourceBase #1730

Closed
matthchr opened this issue Aug 19, 2021 · 3 comments
Closed

Not all resources implement ResourceBase #1730

matthchr opened this issue Aug 19, 2021 · 3 comments
Milestone

Comments

@matthchr
Copy link
Member

Describe the current behavior
The resource manager schema implies that all resources implement resourceBase, which has tags and a few other properties. This is not correct though, there are multiple "kinds" of ARM resources and some of the (Proxy) don't have to support tags. See this for details.

Describe the improvement
The Swagger specifications seem to correctly encode this information, see for example the ASK AgentPool resource which doesn't support tags according to Swagger, but which incorrectly is marked as supporting tags according to the resource manager schema JSON document.

We should stop forcing all types to inherit these ResourceBase properties, as not all of them do.

@matthchr
Copy link
Member Author

@matthchr
Copy link
Member Author

matthchr commented Mar 7, 2022

This is fixed by #2084, probably we can close this

@theunrepentantgeek
Copy link
Member

Verified as fixed in #2323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants