Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update original file path value in detect change request to APIView #9955

Merged

Conversation

praveenkuttappan
Copy link
Member

Some languages generate API review token file in CI side and some languages passes source only to APIView. When both code file and original source file are passed to APIView then it downloads package directory as zip and iterate over the zip to identify the files. But if original file only is passed to APIview then it downloads just that file.

Script was sending full path for original file along with code file and APIView ignores the original file when it does not match the file name in zip.

@praveenkuttappan praveenkuttappan requested a review from a team as a code owner March 3, 2025 03:27
@praveenkuttappan praveenkuttappan self-assigned this Mar 3, 2025
@praveenkuttappan praveenkuttappan added APIView Central-EngSys This issue is owned by the Engineering System team. labels Mar 3, 2025
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

praveenkuttappan added a commit to Azure/azure-sdk-for-js that referenced this pull request Mar 3, 2025
@praveenkuttappan praveenkuttappan merged commit 14a2813 into Azure:main Mar 3, 2025
18 checks passed
@praveenkuttappan praveenkuttappan deleted the fix_detect_api_changes_script branch March 3, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIView Central-EngSys This issue is owned by the Engineering System team.
Projects
Status: ✅ Done
Status: 🔬 Dev in PR
Development

Successfully merging this pull request may close these issues.

4 participants