Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APIView is showing diff lines even without selecting a diff revision #8724

Closed
praveenkuttappan opened this issue Jul 30, 2024 · 2 comments · Fixed by #8799
Closed

APIView is showing diff lines even without selecting a diff revision #8724

praveenkuttappan opened this issue Jul 30, 2024 · 2 comments · Fixed by #8799
Assignees
@chidozieononiwu
Labels
APIView Central-EngSys This issue is owned by the Engineering System team.

Comments

@praveenkuttappan
Copy link
Member

APIView shows diff lines in view even when a diff revision is not selected. Below screenshot shows that diff revision is empty but APIView view section shows deleted lines.

I don't have a diff selected, yet the view shows me removed members. is this a bug or how should I interpret it?

image
@praveenkuttappan praveenkuttappan added APIView Central-EngSys This issue is owned by the Engineering System team. labels Jul 30, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in ApiView Jul 30, 2024
@maririos maririos moved this from 🆕 New to 📋 Backlog in ApiView Jul 31, 2024
@maririos
Copy link
Member

@praveenkuttappan could you add the link to the APIView ?

@praveenkuttappan
Copy link
Member Author

@praveenkuttappan could you add the link to the APIView ?

I don't have the URL for the reported issue. But I was able to repro it by first checking the diff and then copying the URL without diff revision and opening it on different browser. It seems @chidozieononiwu is aware of this issue.
https://spa.apiview.dev/review/76332000a1a44557b19f7a7eacc39624?activeApiRevisionId=7da1191982e44dc390026416c92b9d12

@chidozieononiwu chidozieononiwu mentioned this issue Aug 7, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in ApiView Aug 8, 2024
@github-project-automation github-project-automation bot moved this from 🤔 Triage to 🎊 Closed in Azure SDK EngSys 🤖🧠 Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chidozieononiwu chidozieononiwu

Labels
APIView Central-EngSys This issue is owned by the Engineering System team.
Projects
ApiView
Status: ✅ Done
Azure SDK EngSys 🤖🧠
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable Caching When Pulling Compressed Files chidozieononiwu/azure-sdk-tools
3 participants
@maririos @chidozieononiwu @praveenkuttappan