Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK Automation] Breaking change should be re-evaluated on each run #8381

Closed
Tracked by #8039
raych1 opened this issue Jun 5, 2024 · 1 comment
Closed
Tracked by #8039

[SDK Automation] Breaking change should be re-evaluated on each run #8381

raych1 opened this issue Jun 5, 2024 · 1 comment
Assignees
@raych1

Comments

@raych1
Copy link
Member

raych1 commented Jun 5, 2024

Context
Currently, the SDK breaking change will be evaluated on each run of the pipeline. But the breaking change labels will be adjusted accordingly only when suppression file exist. When suppression file doesn't exist, if the generated SDK in the latest pipeline run removes the potential breaking change, the related BreakingChange-Sdk-{Language} won't be deleted.

Expected
Breaking change labels need to be adjusted even if the suppression file does not eixst.
@raych1 raych1 self-assigned this Jun 5, 2024
@raych1 raych1 mentioned this issue Jun 5, 2024
Closed
@raych1
Copy link
Member Author

raych1 commented Jun 21, 2024

This issue has been fixed.

@raych1 raych1 closed this as completed Jun 21, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in API to SDK automation Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raych1 raych1

Labels
None yet
Projects
API to SDK automation
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@raych1