-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate azure-dev
repo to use the new Check Enforcer and decommission the obsolete CheckEnforcer
tool
#4991
Comments
azure-dev
to use the new Check Enforcer and decommission the obsolete CheckEnforcer
toolazure-dev
repo to use the new Check Enforcer and decommission the obsolete CheckEnforcer
tool
You should be unblocked on this now. These are done:
|
I asked question related to that here: |
Per this comment and my discussion with @benbp, I will delete the no longer used Azure resources related to CheckEnforcer. The exact list of resources I am going to delete is listed here, on Azure SDK / Engineering System Teams channel. Update 1/25/2023 10:40 PM PST: I have deleted the resource groups. |
@weshaggard we could also go in and delete the github app, but I'm wondering whether we want to keep it around for future use given the steps it takes to onboard an app into azure (though I'm not a fan of continuing to use the old name). |
I think the app is also shared with webhook router for the same reasons of setting up is costly so we should probably keep the app around until we decommission that as well. |
Current Check Enforcer tool is a GitHub action living in
azure-sdk-actions
repo.However, there is also an obsolete Check Enforcer in use, which should be decommissioned. I made a PR doing that here:
Turns out, we cannot delete it yet, as it is being used, at least by
azure-dev
repo. To migrateazure-dev
to use the new Check Enforcer, we need to update the workflows inazure-dev
repo to call into the GitHub action-based Check Enforcer workflow,.github/workflows/event.yml
.For details and alternative approaches we considered, see that PR's discussion, especially the Teams discussion linked from this comment.
Once we migrate
azure-dev
to the new Check Enforcer, we should decommission the old Check Enforcer by doing the following:eng/CHECKENFORCER
files;CHECKENFORCER
files are per-repo configs for what the help comments Check Enforcer made should read. These now live in theazure-sdk-actions
repo and are no longer customizable on a per-repo basis;Once we decommission the old Check Enforcer, we now should be able to also decomission
WebhookRouter
tools, as captured by this issue:WebhookRouter
tool downstream consumers and then the tool itself #4992The text was updated successfully, but these errors were encountered: