Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate azure-dev repo to use the new Check Enforcer and decommission the obsolete CheckEnforcer tool #4991

Open
konrad-jamrozik opened this issue Dec 19, 2022 · 5 comments
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@konrad-jamrozik
Copy link
Contributor

konrad-jamrozik commented Dec 19, 2022

Current Check Enforcer tool is a GitHub action living in azure-sdk-actions repo.

However, there is also an obsolete Check Enforcer in use, which should be decommissioned. I made a PR doing that here:

Turns out, we cannot delete it yet, as it is being used, at least by azure-dev repo. To migrate azure-dev to use the new Check Enforcer, we need to update the workflows in azure-dev repo to call into the GitHub action-based Check Enforcer workflow, .github/workflows/event.yml.
For details and alternative approaches we considered, see that PR's discussion, especially the Teams discussion linked from this comment.

Once we migrate azure-dev to the new Check Enforcer, we should decommission the old Check Enforcer by doing the following:

  • delete the source code and pipeline as proposed by Delete obsolete CheckEnforcer tool #4963;
  • delete all eng/CHECKENFORCER files; CHECKENFORCER files are per-repo configs for what the help comments Check Enforcer made should read. These now live in the azure-sdk-actions repo and are no longer customizable on a per-repo basis;
  • update all docs to point to the new Check Enforcer.

Once we decommission the old Check Enforcer, we now should be able to also decomission WebhookRouter tools, as captured by this issue:

@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Dec 19, 2022
@konrad-jamrozik konrad-jamrozik changed the title Migrate azure-dev to use the new Check Enforcer and decommission the obsolete CheckEnforcer tool Migrate azure-dev repo to use the new Check Enforcer and decommission the obsolete CheckEnforcer tool Dec 19, 2022
@konrad-jamrozik konrad-jamrozik added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 19, 2022
@konrad-jamrozik konrad-jamrozik self-assigned this Dec 21, 2022
@kurtzeborn
Copy link
Member

You should be unblocked on this now. These are done:

  • delete all eng/CHECKENFORCER files; CHECKENFORCER files are per-repo configs for what the help comments Check Enforcer made should read. These now live in the azure-sdk-actions repo and are no longer customizable on a per-repo basis;
  • update all docs to point to the new Check Enforcer.

@kurtzeborn kurtzeborn moved this from 🤔Triage to 📋Backlog in Azure SDK EngSys 🤖🧠 Jan 23, 2023
@kurtzeborn kurtzeborn removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 23, 2023
@konrad-jamrozik
Copy link
Contributor Author

You should be unblocked on this now. These are done:

  • delete all eng/CHECKENFORCER files; CHECKENFORCER files are per-repo configs for what the help comments Check Enforcer made should read. These now live in the azure-sdk-actions repo and are no longer customizable on a per-repo basis;
  • update all docs to point to the new Check Enforcer.

I asked question related to that here:

@konrad-jamrozik
Copy link
Contributor Author

konrad-jamrozik commented Jan 26, 2023

Per this comment and my discussion with @benbp, I will delete the no longer used Azure resources related to CheckEnforcer. The exact list of resources I am going to delete is listed here, on Azure SDK / Engineering System Teams channel.

Update 1/25/2023 10:40 PM PST: I have deleted the resource groups.

@benbp
Copy link
Member

benbp commented Jan 26, 2023

@weshaggard we could also go in and delete the github app, but I'm wondering whether we want to keep it around for future use given the steps it takes to onboard an app into azure (though I'm not a fan of continuing to use the old name).

@weshaggard
Copy link
Member

I think the app is also shared with webhook router for the same reasons of setting up is costly so we should probably keep the app around until we decommission that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Status: 📋 Backlog
Development

No branches or pull requests

4 participants