Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG Bash] Azure KeyVault SDK uses hardcoded version of _models #21623

Closed
logachev opened this issue Nov 5, 2021 · 1 comment · Fixed by #22211
Closed

[BUG Bash] Azure KeyVault SDK uses hardcoded version of _models #21623

logachev opened this issue Nov 5, 2021 · 1 comment · Fixed by #22211
Assignees
@mccoyp
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. KeyVault MQ This issue is part of a "milestone of quality" initiative.
Milestone
[2021] December

Comments

@logachev
Copy link

logachev commented Nov 5, 2021

Describe the bug
Azure KeyvAult SDKs reference specific API version (7.1) in its code: https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_models.py#L7

It makes it impossible to use scripts that trim size of Azure SDKs and it also violates established patterns of dynamic versions usage.

https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_models.py#L7
@logachev logachev added the Mgmt This issue is related to a management-plane library. label Nov 5, 2021
@ghost ghost added customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Nov 5, 2021
@mccoyp
Copy link
Member

mccoyp commented Nov 6, 2021

Hi @logachev, thank you for opening this issue! I'll add this item to our upcoming milestone.

@mccoyp mccoyp self-assigned this Nov 6, 2021
@mccoyp mccoyp added Client This issue points to a problem in the data-plane of the library. KeyVault MQ This issue is part of a "milestone of quality" initiative. and removed Mgmt This issue is related to a management-plane library. labels Nov 6, 2021
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Nov 6, 2021
@mccoyp mccoyp added this to the [2021] December milestone Nov 6, 2021
@mccoyp mccoyp added bug This issue requires a change to an existing behavior in the product in order to be resolved. and removed needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Nov 6, 2021
@logachev logachev mentioned this issue Nov 10, 2021
Open
@mccoyp mccoyp mentioned this issue Dec 17, 2021
Merged
6 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mccoyp mccoyp

Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. KeyVault MQ This issue is part of a "milestone of quality" initiative.
Projects
None yet
Milestone
[2021] December
Development

Successfully merging a pull request may close this issue.

[Key Vault] Remove references to specific generated API versions mccoyp/azure-sdk-for-python
2 participants
@logachev @mccoyp