[Messaging] Fix Functions test host credential use #48389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquire
added
Client
|
API change check API changes are not detected in this pull request. |
|
/azp run net - servicebus - functions - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
The focus of these changes is to fix the approach used for token credential management in the Function extensions end-to-end tests for Event Hubs and Service Bus. The previous approach used simple logic to set in-memory configuration with assumptions about the test environment. These assumptions are no longer accurate with the security changes in the testing pipelines. The new approach delegates to the test environment for credential management, as it has the conditional logic for environmental factors needed for credential selection and creation. The configuration-to-credential mapping and creation logic is part of the `Microsoft.Extensions.Azure` package and has full test coverage there; there is no benefit to duplicating test environment logic just to force Function configuration to control the credential locally for the test host.
jsquire
force-pushed
the
servicebus/func-tests
branch
from
3a41948 to
f492d32
Compare
|
/azp run net - servicebus - functions - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run net - eventhub - functions - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsquire
requested review from
christothes,
JoshLove-msft,
m-redding and
jeo02
JoshLove-msft
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The focus of these changes is to fix the approach used for token credential management in the Function extensions end-to-end tests for Event Hubs and Service Bus. The previous approach used simple logic to set in-memory configuration with assumptions about the test environment. These assumptions are no longer accurate with the security changes in the testing pipelines.
The new approach delegates to the test environment for credential management, as it has the conditional logic for environmental factors needed for credential selection and creation. The configuration-to-credential mapping and creation logic is part of the
Microsoft.Extensions.Azurepackage and has full test coverage there; there is no benefit to duplicating test environment logic just to force Function configuration to control the credential locally for the test host.References and resources