From bc75d8100e42fbcaba15df2021d5c3b5cfaa289e Mon Sep 17 00:00:00 2001 From: Amanda Nguyen Date: Wed, 10 Jul 2024 11:13:02 -0700 Subject: [PATCH 1/6] WIP --- .../src/DebugLogger.cs | 22 +++++++++++++ .../src/JobPartInternal.cs | 31 ++++++++++--------- .../tests/PauseResumeTransferTests.cs | 24 +++++++------- 3 files changed, 51 insertions(+), 26 deletions(-) create mode 100644 sdk/storage/Azure.Storage.DataMovement/src/DebugLogger.cs diff --git a/sdk/storage/Azure.Storage.DataMovement/src/DebugLogger.cs b/sdk/storage/Azure.Storage.DataMovement/src/DebugLogger.cs new file mode 100644 index 000000000000..5883accc1aba --- /dev/null +++ b/sdk/storage/Azure.Storage.DataMovement/src/DebugLogger.cs @@ -0,0 +1,22 @@ +// Copyright (c) Microsoft Corporation. All rights reserved. +// Licensed under the MIT License. + +using System; +using System.Collections.Generic; +using System.Text; + +namespace Azure.Storage.DataMovement +{ + internal static class DebugLogger + { + public static void Log(string message) + { + int logCount = 1; + string _logPath = $"C:\\Users\\amnguye\\OneDrive - Microsoft\\Documents\\Debug_Logs\\debug{logCount}.log"; + using (System.IO.StreamWriter file = new System.IO.StreamWriter(_logPath, true)) + { + file.WriteLine(message); + } + } + } +} diff --git a/sdk/storage/Azure.Storage.DataMovement/src/JobPartInternal.cs b/sdk/storage/Azure.Storage.DataMovement/src/JobPartInternal.cs index 979268acf849..e3997f03b4ac 100644 --- a/sdk/storage/Azure.Storage.DataMovement/src/JobPartInternal.cs +++ b/sdk/storage/Azure.Storage.DataMovement/src/JobPartInternal.cs @@ -127,8 +127,11 @@ internal abstract class JobPartInternal /// public SyncAsyncEventHandler SingleTransferCompletedEventHandler { get; internal set; } - private List> _chunkTasks; - private List> _chunkTaskSources; + /// + /// Represents the current state of the job part. + /// + private int _currentChunkCount; + private int _completedChunkCount; protected bool _queueingTasks = false; /// @@ -195,8 +198,8 @@ internal JobPartInternal( StorageResourceCreationPreference.FailIfExists : createMode; Length = length; - _chunkTasks = new List>(); - _chunkTaskSources = new List>(); + _currentChunkCount = 0; + _completedChunkCount = 0; } public void SetQueueChunkDelegate(QueueChunkDelegate chunkDelegate) @@ -212,26 +215,20 @@ public void SetQueueChunkDelegate(QueueChunkDelegate chunkDelegate) /// public async Task QueueChunkToChannelAsync(Func chunkTask) { - // Attach TaskCompletionSource - TaskCompletionSource chunkCompleted = new TaskCompletionSource( - false, - TaskCreationOptions.RunContinuationsAsynchronously); - _chunkTaskSources.Add(chunkCompleted); - _chunkTasks.Add(chunkCompleted.Task); - + Interlocked.Increment(ref _currentChunkCount); await QueueChunk( async () => { try { await Task.Run(chunkTask).ConfigureAwait(false); - chunkCompleted.SetResult(true); - await CheckAndUpdateCancellationStateAsync().ConfigureAwait(false); } catch (Exception ex) { await InvokeFailedArg(ex).ConfigureAwait(false); } + Interlocked.Increment(ref _completedChunkCount); + await CheckAndUpdateCancellationStateAsync().ConfigureAwait(false); }).ConfigureAwait(false); } @@ -424,6 +421,10 @@ await PartTransferStatusEventHandler.RaiseAsync( .ConfigureAwait(false); } } + else if (ex is TaskCanceledException) + { + System.Diagnostics.Debug.WriteLine($"TaskCancellationToken Completion State Part:{PartNumber} | PreviousJobPartState: {JobPartStatus.State} (InvokeFailedArg)"); + } try { @@ -570,12 +571,14 @@ internal async Task CheckAndUpdateCancellationStateAsync() if (JobPartStatus.State == DataTransferState.Pausing || JobPartStatus.State == DataTransferState.Stopping) { - if (!_queueingTasks && _chunkTasks.All((Task task) => (task.IsCompleted))) + if (!_queueingTasks && _currentChunkCount == _completedChunkCount) { DataTransferState newState = JobPartStatus.State == DataTransferState.Pausing ? DataTransferState.Paused : DataTransferState.Completed; + System.Diagnostics.Debug.WriteLine($"Setting Completion State Part:{PartNumber} Status:{newState.ToString()} | PreviousJobPartState: {JobPartStatus.State} (CheckAndUpdateCancellationStateAsync)"); await OnTransferStateChangedAsync(newState).ConfigureAwait(false); + System.Diagnostics.Debug.WriteLine($"Finished Completion State Part:{PartNumber} Status:{newState.ToString()} (CheckAndUpdateCancellationStateAsync)"); } } } diff --git a/sdk/storage/Azure.Storage.DataMovement/tests/PauseResumeTransferTests.cs b/sdk/storage/Azure.Storage.DataMovement/tests/PauseResumeTransferTests.cs index 08ccfab35e1d..74f6196cdf15 100644 --- a/sdk/storage/Azure.Storage.DataMovement/tests/PauseResumeTransferTests.cs +++ b/sdk/storage/Azure.Storage.DataMovement/tests/PauseResumeTransferTests.cs @@ -230,7 +230,7 @@ private async Task CreateSingleLongTransferAsync( return await manager.StartTransferAsync(sourceResource, destinationResource, transferOptions); } - [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] + //[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] [RecordedTest] [TestCase(TransferDirection.Upload)] [TestCase(TransferDirection.Download)] @@ -284,7 +284,7 @@ public async Task TryPauseTransferAsync_Id(TransferDirection transferType) Assert.IsTrue(File.Exists(fileName.FullPath)); } - [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] + //[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] [RecordedTest] [TestCase(TransferDirection.Upload)] [TestCase(TransferDirection.Download)] @@ -354,7 +354,7 @@ public void TryPauseTransferAsync_Error() Assert.CatchAsync(async () => await transferManager.PauseTransferIfRunningAsync("bad transfer Id")); } - [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] + //[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] [RecordedTest] [TestCase(TransferDirection.Upload)] [TestCase(TransferDirection.Download)] @@ -413,7 +413,7 @@ public async Task TryPauseTransferAsync_AlreadyPaused(TransferDirection transfer Assert.IsTrue(File.Exists(fileName.FullPath)); } - [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] + //[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] [RecordedTest] [TestCase(TransferDirection.Upload)] [TestCase(TransferDirection.Download)] @@ -492,7 +492,7 @@ await AssertSourceAndDestinationAsync( destinationContainer: destinationContainer.Container); } - [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] + //[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] [RecordedTest] [TestCase(TransferDirection.Upload)] [TestCase(TransferDirection.Download)] @@ -567,7 +567,7 @@ await AssertSourceAndDestinationAsync( destinationContainer: destinationContainer.Container); } - [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] + //[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] [Test] [LiveOnly] [TestCase(TransferDirection.Upload)] @@ -811,7 +811,7 @@ private async Task CreateDirectoryLongTransferAsync( return await manager.StartTransferAsync(sourceResource, destinationResource, transferOptions); } - [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] + //[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] [RecordedTest] [TestCase(TransferDirection.Upload)] [TestCase(TransferDirection.Download)] @@ -862,7 +862,7 @@ public async Task TryPauseTransferAsync_Id_Directory(TransferDirection transferT Assert.AreEqual(DataTransferState.Paused, transfer.TransferStatus.State); } - [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] + //[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] [RecordedTest] [TestCase(TransferDirection.Upload)] [TestCase(TransferDirection.Download)] @@ -913,7 +913,7 @@ public async Task TryPauseTransferAsync_DataTransfer_Directory(TransferDirection Assert.AreEqual(DataTransferState.Paused, transfer.TransferStatus.State); } - [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] + //[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] [RecordedTest] [TestCase(TransferDirection.Upload)] [TestCase(TransferDirection.Download)] @@ -970,7 +970,7 @@ public async Task TryPauseTransferAsync_AlreadyPaused_Directory(TransferDirectio Assert.AreEqual(DataTransferState.Paused, transfer.TransferStatus.State); } - [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] + //[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] [RecordedTest] [TestCase(TransferDirection.Upload)] [TestCase(TransferDirection.Download)] @@ -1057,7 +1057,7 @@ await AssertDirectorySourceAndDestinationAsync( destinationContainer: destinationContainer.Container); } - [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] + //[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] [RecordedTest] [TestCase(TransferDirection.Upload)] [TestCase(TransferDirection.Download)] @@ -1144,7 +1144,7 @@ await AssertDirectorySourceAndDestinationAsync( destinationContainer: destinationContainer.Container); } - [Ignore("Likely to fail in pipelines and takes a while to run.")] + //[Ignore("Likely to fail in pipelines and takes a while to run.")] [Test, Pairwise] [LiveOnly] public async Task ResumeTransferAsync_Directory_Large( From a7e80cfc27850b62075ea05c22475080ed79b7f4 Mon Sep 17 00:00:00 2001 From: Amanda Nguyen Date: Mon, 15 Jul 2024 14:54:54 -0700 Subject: [PATCH 2/6] Make CI happy --- .../CHANGELOG.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/sdk/storage/Microsoft.Azure.WebJobs.Extensions.Storage.Common/CHANGELOG.md b/sdk/storage/Microsoft.Azure.WebJobs.Extensions.Storage.Common/CHANGELOG.md index 36e9ae6e255c..c2b75f018950 100644 --- a/sdk/storage/Microsoft.Azure.WebJobs.Extensions.Storage.Common/CHANGELOG.md +++ b/sdk/storage/Microsoft.Azure.WebJobs.Extensions.Storage.Common/CHANGELOG.md @@ -1,5 +1,15 @@ # Release History +## 5.0.0-beta.4 (Unreleased) + +### Features Added + +### Breaking Changes + +### Bugs Fixed + +### Other Changes + ## 5.0.0-beta.3 (2021-03-09) - This release contains bug fixes to improve quality. From 514237b838d52efd0e2aa2261715386adc85758d Mon Sep 17 00:00:00 2001 From: Amanda Nguyen Date: Mon, 15 Jul 2024 14:55:18 -0700 Subject: [PATCH 3/6] Revert "Make CI happy" This reverts commit a7e80cfc27850b62075ea05c22475080ed79b7f4. --- .../CHANGELOG.md | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/sdk/storage/Microsoft.Azure.WebJobs.Extensions.Storage.Common/CHANGELOG.md b/sdk/storage/Microsoft.Azure.WebJobs.Extensions.Storage.Common/CHANGELOG.md index c2b75f018950..36e9ae6e255c 100644 --- a/sdk/storage/Microsoft.Azure.WebJobs.Extensions.Storage.Common/CHANGELOG.md +++ b/sdk/storage/Microsoft.Azure.WebJobs.Extensions.Storage.Common/CHANGELOG.md @@ -1,15 +1,5 @@ # Release History -## 5.0.0-beta.4 (Unreleased) - -### Features Added - -### Breaking Changes - -### Bugs Fixed - -### Other Changes - ## 5.0.0-beta.3 (2021-03-09) - This release contains bug fixes to improve quality. From 16956851e0dd024daa73cf35c954a02f6d7eda94 Mon Sep 17 00:00:00 2001 From: Amanda Nguyen Date: Mon, 15 Jul 2024 15:44:58 -0700 Subject: [PATCH 4/6] WIP --- .../Azure.Storage.DataMovement/src/JobPartInternal.cs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sdk/storage/Azure.Storage.DataMovement/src/JobPartInternal.cs b/sdk/storage/Azure.Storage.DataMovement/src/JobPartInternal.cs index e3997f03b4ac..907ca7d008fe 100644 --- a/sdk/storage/Azure.Storage.DataMovement/src/JobPartInternal.cs +++ b/sdk/storage/Azure.Storage.DataMovement/src/JobPartInternal.cs @@ -571,14 +571,15 @@ internal async Task CheckAndUpdateCancellationStateAsync() if (JobPartStatus.State == DataTransferState.Pausing || JobPartStatus.State == DataTransferState.Stopping) { + DebugLogger.Log($"CheckAndUpdateCancellationStateAsync Part:{PartNumber} CurrentChunkCount:{_currentChunkCount} CompletedChunkCount:{_completedChunkCount} QueueingTasks:{_queueingTasks.ToString()}"); if (!_queueingTasks && _currentChunkCount == _completedChunkCount) { DataTransferState newState = JobPartStatus.State == DataTransferState.Pausing ? DataTransferState.Paused : DataTransferState.Completed; - System.Diagnostics.Debug.WriteLine($"Setting Completion State Part:{PartNumber} Status:{newState.ToString()} | PreviousJobPartState: {JobPartStatus.State} (CheckAndUpdateCancellationStateAsync)"); + DebugLogger.Log($"Setting Completion State Part:{PartNumber} Status:{newState.ToString()} | PreviousJobPartState: {JobPartStatus.State} (CheckAndUpdateCancellationStateAsync)"); await OnTransferStateChangedAsync(newState).ConfigureAwait(false); - System.Diagnostics.Debug.WriteLine($"Finished Completion State Part:{PartNumber} Status:{newState.ToString()} (CheckAndUpdateCancellationStateAsync)"); + DebugLogger.Log($"Finished Completion State Part:{PartNumber} Status:{newState.ToString()} (CheckAndUpdateCancellationStateAsync)"); } } } From 2dd8be4e830111306e8e0139afa690f641fb03e8 Mon Sep 17 00:00:00 2001 From: Amanda Nguyen Date: Tue, 16 Jul 2024 11:13:07 -0700 Subject: [PATCH 5/6] Cleanup --- .../src/DebugLogger.cs | 22 ------------------- .../src/JobPartInternal.cs | 3 --- 2 files changed, 25 deletions(-) delete mode 100644 sdk/storage/Azure.Storage.DataMovement/src/DebugLogger.cs diff --git a/sdk/storage/Azure.Storage.DataMovement/src/DebugLogger.cs b/sdk/storage/Azure.Storage.DataMovement/src/DebugLogger.cs deleted file mode 100644 index 5883accc1aba..000000000000 --- a/sdk/storage/Azure.Storage.DataMovement/src/DebugLogger.cs +++ /dev/null @@ -1,22 +0,0 @@ -// Copyright (c) Microsoft Corporation. All rights reserved. -// Licensed under the MIT License. - -using System; -using System.Collections.Generic; -using System.Text; - -namespace Azure.Storage.DataMovement -{ - internal static class DebugLogger - { - public static void Log(string message) - { - int logCount = 1; - string _logPath = $"C:\\Users\\amnguye\\OneDrive - Microsoft\\Documents\\Debug_Logs\\debug{logCount}.log"; - using (System.IO.StreamWriter file = new System.IO.StreamWriter(_logPath, true)) - { - file.WriteLine(message); - } - } - } -} diff --git a/sdk/storage/Azure.Storage.DataMovement/src/JobPartInternal.cs b/sdk/storage/Azure.Storage.DataMovement/src/JobPartInternal.cs index 907ca7d008fe..2991df8c2b5f 100644 --- a/sdk/storage/Azure.Storage.DataMovement/src/JobPartInternal.cs +++ b/sdk/storage/Azure.Storage.DataMovement/src/JobPartInternal.cs @@ -571,15 +571,12 @@ internal async Task CheckAndUpdateCancellationStateAsync() if (JobPartStatus.State == DataTransferState.Pausing || JobPartStatus.State == DataTransferState.Stopping) { - DebugLogger.Log($"CheckAndUpdateCancellationStateAsync Part:{PartNumber} CurrentChunkCount:{_currentChunkCount} CompletedChunkCount:{_completedChunkCount} QueueingTasks:{_queueingTasks.ToString()}"); if (!_queueingTasks && _currentChunkCount == _completedChunkCount) { DataTransferState newState = JobPartStatus.State == DataTransferState.Pausing ? DataTransferState.Paused : DataTransferState.Completed; - DebugLogger.Log($"Setting Completion State Part:{PartNumber} Status:{newState.ToString()} | PreviousJobPartState: {JobPartStatus.State} (CheckAndUpdateCancellationStateAsync)"); await OnTransferStateChangedAsync(newState).ConfigureAwait(false); - DebugLogger.Log($"Finished Completion State Part:{PartNumber} Status:{newState.ToString()} (CheckAndUpdateCancellationStateAsync)"); } } } From 1ae611e16df605d1cfad62472be76ed1b3c4b72f Mon Sep 17 00:00:00 2001 From: Amanda Nguyen Date: Tue, 16 Jul 2024 11:17:17 -0700 Subject: [PATCH 6/6] More cleanup --- .../src/JobPartInternal.cs | 4 ---- .../tests/PauseResumeTransferTests.cs | 24 +++++++++---------- 2 files changed, 12 insertions(+), 16 deletions(-) diff --git a/sdk/storage/Azure.Storage.DataMovement/src/JobPartInternal.cs b/sdk/storage/Azure.Storage.DataMovement/src/JobPartInternal.cs index 2991df8c2b5f..d0ca5e0d5a64 100644 --- a/sdk/storage/Azure.Storage.DataMovement/src/JobPartInternal.cs +++ b/sdk/storage/Azure.Storage.DataMovement/src/JobPartInternal.cs @@ -421,10 +421,6 @@ await PartTransferStatusEventHandler.RaiseAsync( .ConfigureAwait(false); } } - else if (ex is TaskCanceledException) - { - System.Diagnostics.Debug.WriteLine($"TaskCancellationToken Completion State Part:{PartNumber} | PreviousJobPartState: {JobPartStatus.State} (InvokeFailedArg)"); - } try { diff --git a/sdk/storage/Azure.Storage.DataMovement/tests/PauseResumeTransferTests.cs b/sdk/storage/Azure.Storage.DataMovement/tests/PauseResumeTransferTests.cs index 74f6196cdf15..08ccfab35e1d 100644 --- a/sdk/storage/Azure.Storage.DataMovement/tests/PauseResumeTransferTests.cs +++ b/sdk/storage/Azure.Storage.DataMovement/tests/PauseResumeTransferTests.cs @@ -230,7 +230,7 @@ private async Task CreateSingleLongTransferAsync( return await manager.StartTransferAsync(sourceResource, destinationResource, transferOptions); } - //[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] + [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] [RecordedTest] [TestCase(TransferDirection.Upload)] [TestCase(TransferDirection.Download)] @@ -284,7 +284,7 @@ public async Task TryPauseTransferAsync_Id(TransferDirection transferType) Assert.IsTrue(File.Exists(fileName.FullPath)); } - //[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] + [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] [RecordedTest] [TestCase(TransferDirection.Upload)] [TestCase(TransferDirection.Download)] @@ -354,7 +354,7 @@ public void TryPauseTransferAsync_Error() Assert.CatchAsync(async () => await transferManager.PauseTransferIfRunningAsync("bad transfer Id")); } - //[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] + [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] [RecordedTest] [TestCase(TransferDirection.Upload)] [TestCase(TransferDirection.Download)] @@ -413,7 +413,7 @@ public async Task TryPauseTransferAsync_AlreadyPaused(TransferDirection transfer Assert.IsTrue(File.Exists(fileName.FullPath)); } - //[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] + [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] [RecordedTest] [TestCase(TransferDirection.Upload)] [TestCase(TransferDirection.Download)] @@ -492,7 +492,7 @@ await AssertSourceAndDestinationAsync( destinationContainer: destinationContainer.Container); } - //[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] + [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] [RecordedTest] [TestCase(TransferDirection.Upload)] [TestCase(TransferDirection.Download)] @@ -567,7 +567,7 @@ await AssertSourceAndDestinationAsync( destinationContainer: destinationContainer.Container); } - //[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] + [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] [Test] [LiveOnly] [TestCase(TransferDirection.Upload)] @@ -811,7 +811,7 @@ private async Task CreateDirectoryLongTransferAsync( return await manager.StartTransferAsync(sourceResource, destinationResource, transferOptions); } - //[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] + [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] [RecordedTest] [TestCase(TransferDirection.Upload)] [TestCase(TransferDirection.Download)] @@ -862,7 +862,7 @@ public async Task TryPauseTransferAsync_Id_Directory(TransferDirection transferT Assert.AreEqual(DataTransferState.Paused, transfer.TransferStatus.State); } - //[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] + [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] [RecordedTest] [TestCase(TransferDirection.Upload)] [TestCase(TransferDirection.Download)] @@ -913,7 +913,7 @@ public async Task TryPauseTransferAsync_DataTransfer_Directory(TransferDirection Assert.AreEqual(DataTransferState.Paused, transfer.TransferStatus.State); } - //[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] + [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] [RecordedTest] [TestCase(TransferDirection.Upload)] [TestCase(TransferDirection.Download)] @@ -970,7 +970,7 @@ public async Task TryPauseTransferAsync_AlreadyPaused_Directory(TransferDirectio Assert.AreEqual(DataTransferState.Paused, transfer.TransferStatus.State); } - //[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] + [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] [RecordedTest] [TestCase(TransferDirection.Upload)] [TestCase(TransferDirection.Download)] @@ -1057,7 +1057,7 @@ await AssertDirectorySourceAndDestinationAsync( destinationContainer: destinationContainer.Container); } - //[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] + [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35439")] [RecordedTest] [TestCase(TransferDirection.Upload)] [TestCase(TransferDirection.Download)] @@ -1144,7 +1144,7 @@ await AssertDirectorySourceAndDestinationAsync( destinationContainer: destinationContainer.Container); } - //[Ignore("Likely to fail in pipelines and takes a while to run.")] + [Ignore("Likely to fail in pipelines and takes a while to run.")] [Test, Pairwise] [LiveOnly] public async Task ResumeTransferAsync_Directory_Large(