Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClientModel: Investigate paging pattern for unbranded clients #42148

Closed
pallavit opened this issue Feb 22, 2024 · 4 comments
Closed

ClientModel: Investigate paging pattern for unbranded clients #42148

pallavit opened this issue Feb 22, 2024 · 4 comments
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. CodeGen Issues that relate to code generation System.ClientModel Base Core library
Milestone
2024-06

Comments

@pallavit
Copy link
Contributor

pallavit commented Feb 22, 2024 •
edited
Loading

This is needed for the preview release currently stated for 5/20

  • Consider the OpenAI paging pattern and other popular paging patterns
  • Investigate whether a given pattern is generic and popular enough to include in System.ClientModel
  • For each paging pattern that is adopted by Client Model, create an issue to track the work for implementation/testing.
@pallavit pallavit added Client This issue points to a problem in the data-plane of the library. System.ClientModel Base Core library labels Feb 22, 2024
@pallavit pallavit added this to the Backlog milestone Feb 23, 2024
@pallavit pallavit added the CodeGen Issues that relate to code generation label Feb 23, 2024
@annelo-msft annelo-msft modified the milestones: Backlog, 2024-04 Mar 12, 2024
@annelo-msft annelo-msft changed the title Enable support for pagination in debranded toolchain ClientModel: Enable support for pagination in debranded toolchain Mar 12, 2024
@pallavit
Copy link
Contributor Author

Why is this p2? Pagination is needed for OpenAI scenarios like Files, Images etc. We currently do not have GA timelines but this is something we will have to think about. For instance, why is this lower priority than Variant type?

@jsquire
Copy link
Member

jsquire commented Mar 19, 2024

Rescoping this to "investigate" because we need to make a decision whether or not there's a paging pattern popular enough that we feel it should be included in Client Model. If the OpenAI implementation is specific to OpenAI, then it should be local to that library.

@jsquire jsquire changed the title ClientModel: Enable support for pagination in debranded toolchain ClientModel: Investigate paging pattern for unbranded clients Mar 19, 2024
@annelo-msft
Copy link
Member

annelo-msft commented Mar 27, 2024 •
edited
Loading

Related to #42487

@joseharriaga - please let us know if this becomes a P0 requirement for OpenAI.

@jsquire jsquire modified the milestones: 2024-04, 2024-05 Apr 30, 2024
@jsquire jsquire modified the milestones: 2024-05, 2024-06 May 20, 2024
@annelo-msft
Copy link
Member

Addressed by #44026

@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. CodeGen Issues that relate to code generation System.ClientModel Base Core library
Projects
None yet
Milestone
2024-06
Development

No branches or pull requests
3 participants
@jsquire @pallavit @annelo-msft