Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide convenience helpers to download response into File, string, Blob, or Buffer #2603

Closed
2 of 4 tasks
jeremymeng opened this issue Apr 30, 2019 · 6 comments
Closed
2 of 4 tasks
Assignees
Labels
APIChange This PR contains an addition or change to the API signature and must be reviewed by an architect. Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. Storage Storage Service (Queues, Blobs, Files)

Comments

@jeremymeng
Copy link
Member

jeremymeng commented Apr 30, 2019

(@XiaoningLiu to provide more details here)
[Non breaking]

Xiaoning might have bandwidth to work on this in June.

  • File
  • String
  • Blob
  • Buffer
@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Apr 30, 2019
@jeremymeng jeremymeng added this to the Sprint 155 milestone May 23, 2019
@jeremymeng
Copy link
Member Author

These would be instance methods on the client type.

@XiaoningLiu
Copy link
Member

@jeremymeng I may have time for this after finishing feature work of next API version. Promising end of June. Or you can pick it up, if it's urgent for you.

@jeremymeng
Copy link
Member Author

The Arch Board definitely want downloadToFile(). Others are tentative.

@jeremymeng
Copy link
Member Author

It might be useful to have downloadToStream() then you can pipe the stream.

The download responses from download() already have the stream.

@ramya-rao-a ramya-rao-a removed this from the Sprint 157 milestone Oct 23, 2019
@ramya-rao-a
Copy link
Contributor

@bterlson, we are moving this out of the current release scope and into the next one.
Can you provide the guidance on what the api should look like here?

@ljian3377 ljian3377 self-assigned this Oct 22, 2020
@ljian3377 ljian3377 added this to the Backlog milestone Oct 22, 2020
@ljian3377 ljian3377 added the APIChange This PR contains an addition or change to the API signature and must be reviewed by an architect. label Oct 22, 2020
@ramya-rao-a ramya-rao-a added the feature-request This issue requires a new behavior in the product in order be resolved. label Sep 22, 2021
Copy link

Hi @jeremymeng, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
APIChange This PR contains an addition or change to the API signature and must be reviewed by an architect. Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

No branches or pull requests

6 participants