Don't stop trying dev credentials on failures #35771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
sdk/identity/azure-identity/src/main/java/com/azure/identity/AzureCliCredential.java
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/src/main/java/com/azure/identity/AzureCliCredential.java
Outdated
Show resolved
Hide resolved
joshfree
added
bug
Fixes Azure#34733 For our dev time credentials we want to always keep going. This change wraps any failure from the credentials in a `CredentialUnavailableException` so `ChainedTokenCredential` will continue them properly. It only does so in the context of a `ChainedTokenCredential`. Regular uses of these credentials is unaffected.
billwert
force-pushed
the
identity-keep-trying-dac-creds
branch
from
87a2af5 to
33f6a77
Compare
g2vinay
reviewed
Jul 19, 2023
...ty/azure-identity/src/main/java/com/azure/identity/implementation/IdentityClientOptions.java
Show resolved
Hide resolved
pvaneck
reviewed
Jul 20, 2023
There was a problem hiding this comment.
Hey, @billwert. Should this logic of always returning CredentialUnavailableException for dev credentials also apply to user-created ChainedTokenCredentials which may contain several dev credentials? Seems like only DAC has isChained set to true.
|
I don’t think so. Once you’re making your own chains you get to set your own policies. Think of this as a DAC policy, not a chained credential policy.
Thanks,
-Bill
…________________________________
From: Paul Van Eck ***@***.***>
Sent: Thursday, July 20, 2023 2:08:32 PM
To: Azure/azure-sdk-for-java ***@***.***>
Cc: Bill Wert ***@***.***>; Mention ***@***.***>
Subject: Re: [Azure/azure-sdk-for-java] Don't stop trying dev credentials on failures (PR #35771)
@pvaneck commented on this pull request.
Hey, @billwert<https://github.com/billwert>. Should this logic of always returning CredentialUnavailableException for dev credentials also apply to user-created ChainedTokenCredentials which may contain several dev credentials? Seems like only DAC has isChained set to true.
—
Reply to this email directly, view it on GitHub<#35771 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABCQI4FKEREQ7ELFFN7ZCPDXRGM5BANCNFSM6AAAAAA2BAYCZE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
g2vinay
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34733
For our dev time credentials we want to always keep going. This change wraps any failure from the credentials in a
CredentialUnavailableExceptionsoChainedTokenCredentialwill continue them properly.