Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Use code injection tool to include code samples from compilable Java code in readme. #6961

Closed
mssfang opened this issue Dec 19, 2019 · 1 comment
Closed

[Doc] Use code injection tool to include code samples from compilable Java code in readme. #6961

mssfang opened this issue Dec 19, 2019 · 1 comment
Assignees
@samvaity
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics

Comments

@mssfang
Copy link
Member

mssfang commented Dec 19, 2019 •
edited
Loading

To have a ReadmeSamples java file to maintain the codesnippet of readme file. So that make sure the readme codesnippet section is compilable.

E.x.,
comment to run: npx embedme sdk//azure-core/README.md
and file to take a look at
./src/samples/java/com/azure/core/http/netty/ReadmeSamples.java
@mssfang mssfang added Client This issue points to a problem in the data-plane of the library. Text Analytics labels Dec 19, 2019
@mssfang mssfang self-assigned this Dec 19, 2019
@mssfang mssfang mentioned this issue Dec 19, 2019
Merged
@mssfang mssfang assigned samvaity and unassigned mssfang Jan 6, 2020
@samvaity samvaity mentioned this issue Jan 6, 2020
Merged
@samvaity
Copy link
Member

samvaity commented Jan 6, 2020

Resolved in #7118

@samvaity samvaity closed this as completed Jan 6, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@samvaity samvaity

Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samvaity @mssfang