Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle incomplete profile updates when intial update comes from a breaking change #2148

Closed
vladbarosan opened this issue Jun 28, 2018 · 3 comments
Assignees

Comments

@vladbarosan
Copy link

  1. Commit A removes a type from an API version so its a breaking change. Profile is also updated as part of that.

  2. Commit B comes and adds a new API version which also doesn't have the type that was removed in Commit A. This is a new api version so not a breaking change. The profile is updated to point to this new API version.

  3. WE want to release a minor version. We dont pick up A, but we pick up B.

=> Problem is now after the B cherry pick, the removed type is still present since it was removed in A but we didn't pickup A.

@vladbarosan vladbarosan added the P1 label Jun 28, 2018
@vladbarosan
Copy link
Author

Right now a workaround is just to ignore the profiles while the picker does the cherry picking and regenerate the profiles after the picker is done.

@vladbarosan
Copy link
Author

@jhendrixMSFT can we document the regeneration of profiles after the picker runs for the minor version updates ?

@vladbarosan
Copy link
Author

Updated the wiki to reflect the additional step needed

@ghost ghost removed the committed label Jul 11, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants