From 62462efa52fd34d877e69ad3ee0f69687b26cd92 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonathan=20C=C3=A1rdenas?= Date: Tue, 21 Jan 2025 13:53:05 -0800 Subject: [PATCH 01/13] comment Error rename --- .../keyvault/Security.KeyVault.Administration/client.tsp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/keyvault/Security.KeyVault.Administration/client.tsp b/specification/keyvault/Security.KeyVault.Administration/client.tsp index 18dfe04c9f0e..89122f319860 100644 --- a/specification/keyvault/Security.KeyVault.Administration/client.tsp +++ b/specification/keyvault/Security.KeyVault.Administration/client.tsp @@ -38,7 +38,7 @@ namespace ClientCustomizations; "csharp" ); @@clientName(KeyVault.Permission, "KeyVaultPermission", "csharp"); -@@clientName(Error, "KeyVaultServiceError", "csharp"); +//@@clientName(Error, "KeyVaultServiceError", "csharp"); @@clientName(KeyVault.DataAction, "KeyVaultDataAction", "csharp"); @@clientName(KeyVault.RestoreOperation, "RestoreDetailsInternal", "csharp"); From 38c878eabb0efdc7e742599544d00785acdb0eef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonathan=20C=C3=A1rdenas?= Date: Tue, 21 Jan 2025 16:14:56 -0800 Subject: [PATCH 02/13] Comment all C# customizations --- .../client.tsp | 222 +++++++++--------- 1 file changed, 111 insertions(+), 111 deletions(-) diff --git a/specification/keyvault/Security.KeyVault.Administration/client.tsp b/specification/keyvault/Security.KeyVault.Administration/client.tsp index 89122f319860..9d19e5cee39b 100644 --- a/specification/keyvault/Security.KeyVault.Administration/client.tsp +++ b/specification/keyvault/Security.KeyVault.Administration/client.tsp @@ -16,120 +16,120 @@ namespace ClientCustomizations; @@clientName(KeyVault.SettingTypeEnum, "KeyVaultSettingType", "java"); //C# customizations -@@clientName(KeyVault.Setting, "KeyVaultSetting", "csharp"); -@@clientName(KeyVault.Setting.value, "Content", "csharp"); -@@clientName(KeyVault.Setting.type, "SettingType", "csharp"); -@@clientName(KeyVault.SettingTypeEnum, "KeyVaultSettingType", "csharp"); -@@clientName(KeyVault.Permission, "KeyVaultPermission", "csharp"); -@@clientName(KeyVault.RoleScope, "KeyVaultRoleScope", "csharp"); -@@clientName(KeyVault.RoleType, "KeyVaultRoleType", "csharp"); -@@clientName(KeyVault.RoleAssignment, "KeyVaultRoleAssignment", "csharp"); -@@clientName(KeyVault.FullBackupOperation, - "FullBackupDetailsInternal", - "csharp" -); -@@clientName(KeyVault.SettingsListResult, "GetSettingsResult", "csharp"); -@@clientName(KeyVault.RoleAssignmentPropertiesWithScope, - "KeyVaultRoleAssignmentProperties", - "csharp" -); -@@clientName(KeyVault.RoleDefinitionType, - "KeyVaultRoleDefinitionType", - "csharp" -); -@@clientName(KeyVault.Permission, "KeyVaultPermission", "csharp"); -//@@clientName(Error, "KeyVaultServiceError", "csharp"); -@@clientName(KeyVault.DataAction, "KeyVaultDataAction", "csharp"); -@@clientName(KeyVault.RestoreOperation, "RestoreDetailsInternal", "csharp"); +// @@clientName(KeyVault.Setting, "KeyVaultSetting", "csharp"); +// @@clientName(KeyVault.Setting.value, "Content", "csharp"); +// @@clientName(KeyVault.Setting.type, "SettingType", "csharp"); +// @@clientName(KeyVault.SettingTypeEnum, "KeyVaultSettingType", "csharp"); +// @@clientName(KeyVault.Permission, "KeyVaultPermission", "csharp"); +// @@clientName(KeyVault.RoleScope, "KeyVaultRoleScope", "csharp"); +// @@clientName(KeyVault.RoleType, "KeyVaultRoleType", "csharp"); +// @@clientName(KeyVault.RoleAssignment, "KeyVaultRoleAssignment", "csharp"); +// @@clientName(KeyVault.FullBackupOperation, +// "FullBackupDetailsInternal", +// "csharp" +// ); +// @@clientName(KeyVault.SettingsListResult, "GetSettingsResult", "csharp"); +// @@clientName(KeyVault.RoleAssignmentPropertiesWithScope, +// "KeyVaultRoleAssignmentProperties", +// "csharp" +// ); +// @@clientName(KeyVault.RoleDefinitionType, +// "KeyVaultRoleDefinitionType", +// "csharp" +// ); +// @@clientName(KeyVault.Permission, "KeyVaultPermission", "csharp"); +// @@clientName(Error, "KeyVaultServiceError", "csharp"); +// @@clientName(KeyVault.DataAction, "KeyVaultDataAction", "csharp"); +// @@clientName(KeyVault.RestoreOperation, "RestoreDetailsInternal", "csharp"); -@@access(KeyVault.RoleAssignmentCreateParameters, Access.internal, "csharp"); -@@access(KeyVault.RoleDefinitionCreateParameters, Access.internal, "csharp"); -@@access(KeyVault.SASTokenParameter, Access.internal, "csharp"); -@@access(KeyVault.SelectiveKeyRestoreOperationParameters, - Access.internal, - "csharp" -); -@@access(KeyVault.RoleDefinitionProperties, Access.internal, "csharp"); +// @@access(KeyVault.RoleAssignmentCreateParameters, Access.internal, "csharp"); +// @@access(KeyVault.RoleDefinitionCreateParameters, Access.internal, "csharp"); +// @@access(KeyVault.SASTokenParameter, Access.internal, "csharp"); +// @@access(KeyVault.SelectiveKeyRestoreOperationParameters, +// Access.internal, +// "csharp" +// ); +// @@access(KeyVault.RoleDefinitionProperties, Access.internal, "csharp"); -@@clientName(KeyVault.FullBackupOperation.azureStorageBlobContainerUri, - "folderUri", - "javascript" -); +// @@clientName(KeyVault.FullBackupOperation.azureStorageBlobContainerUri, +// "folderUri", +// "javascript" +// ); -@client( - { - name: "BackupRestoreRestClient", - service: KeyVault, - }, - "csharp" -) -interface BackupRestoreRestClient { - #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" - fullBackup is KeyVault.fullBackup; - #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" - #suppress "@azure-tools/typespec-azure-core/use-standard-names" "Operation name has already shipped" - fullBackupStatus is KeyVault.fullBackupStatus; - #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" - preFullBackup is KeyVault.preFullBackup; - #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" - #suppress "@azure-tools/typespec-azure-core/use-standard-names" "Operation name has already shipped" - restoreStatus is KeyVault.restoreStatus; - #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" - preFullRestoreOperation is KeyVault.preFullRestoreOperation; - #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" - fullRestoreOperation is KeyVault.fullRestoreOperation; - #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" - selectiveKeyRestoreOperation is KeyVault.selectiveKeyRestoreOperation; -} +// @client( +// { +// name: "BackupRestoreRestClient", +// service: KeyVault, +// }, +// "csharp" +// ) +// interface BackupRestoreRestClient { +// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" +// fullBackup is KeyVault.fullBackup; +// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" +// #suppress "@azure-tools/typespec-azure-core/use-standard-names" "Operation name has already shipped" +// fullBackupStatus is KeyVault.fullBackupStatus; +// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" +// preFullBackup is KeyVault.preFullBackup; +// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" +// #suppress "@azure-tools/typespec-azure-core/use-standard-names" "Operation name has already shipped" +// restoreStatus is KeyVault.restoreStatus; +// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" +// preFullRestoreOperation is KeyVault.preFullRestoreOperation; +// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" +// fullRestoreOperation is KeyVault.fullRestoreOperation; +// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" +// selectiveKeyRestoreOperation is KeyVault.selectiveKeyRestoreOperation; +// } -@client( - { - name: "RoleAssignmentsRestClient", - service: KeyVault, - }, - "csharp" -) -interface RoleAssignmentsRestClient { - #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" - delete is KeyVault.RoleAssignments.delete; - #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" - create is KeyVault.RoleAssignments.create; - #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" - get is KeyVault.RoleAssignments.get; - #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" - listForScope is KeyVault.RoleAssignments.listForScope; -} +// @client( +// { +// name: "RoleAssignmentsRestClient", +// service: KeyVault, +// }, +// "csharp" +// ) +// interface RoleAssignmentsRestClient { +// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" +// delete is KeyVault.RoleAssignments.delete; +// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" +// create is KeyVault.RoleAssignments.create; +// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" +// get is KeyVault.RoleAssignments.get; +// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" +// listForScope is KeyVault.RoleAssignments.listForScope; +// } -@client( - { - name: "RoleDefinitionsRestClient", - service: KeyVault, - }, - "csharp" -) -interface RoleDefinitionsRestClient { - #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" - delete is KeyVault.RoleDefinitions.delete; - #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" - createOrUpdate is KeyVault.RoleDefinitions.createOrUpdate; - #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" - get is KeyVault.RoleDefinitions.get; - #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" - list is KeyVault.RoleDefinitions.list; -} +// @client( +// { +// name: "RoleDefinitionsRestClient", +// service: KeyVault, +// }, +// "csharp" +// ) +// interface RoleDefinitionsRestClient { +// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" +// delete is KeyVault.RoleDefinitions.delete; +// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" +// createOrUpdate is KeyVault.RoleDefinitions.createOrUpdate; +// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" +// get is KeyVault.RoleDefinitions.get; +// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" +// list is KeyVault.RoleDefinitions.list; +// } -@client( - { - name: "SettingsRestClient", - service: KeyVault, - }, - "csharp" -) -interface SettingsRestClient { - #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" - updateSetting is KeyVault.updateSetting; - #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" - getSetting is KeyVault.getSetting; - #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" - getSettings is KeyVault.getSettings; -} +// @client( +// { +// name: "SettingsRestClient", +// service: KeyVault, +// }, +// "csharp" +// ) +// interface SettingsRestClient { +// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" +// updateSetting is KeyVault.updateSetting; +// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" +// getSetting is KeyVault.getSetting; +// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" +// getSettings is KeyVault.getSettings; +// } From 0f86b2689eb30700b3b634a428b56ca7e37885aa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonathan=20C=C3=A1rdenas?= Date: Tue, 21 Jan 2025 16:19:29 -0800 Subject: [PATCH 03/13] KeyVaultSettingValue --- .../keyvault/Security.KeyVault.Administration/client.tsp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/keyvault/Security.KeyVault.Administration/client.tsp b/specification/keyvault/Security.KeyVault.Administration/client.tsp index 9d19e5cee39b..3cec123f7b38 100644 --- a/specification/keyvault/Security.KeyVault.Administration/client.tsp +++ b/specification/keyvault/Security.KeyVault.Administration/client.tsp @@ -16,8 +16,8 @@ namespace ClientCustomizations; @@clientName(KeyVault.SettingTypeEnum, "KeyVaultSettingType", "java"); //C# customizations -// @@clientName(KeyVault.Setting, "KeyVaultSetting", "csharp"); -// @@clientName(KeyVault.Setting.value, "Content", "csharp"); +//@@clientName(KeyVault.Setting, "KeyVaultSetting", "csharp"); +@@clientName(KeyVault.Setting.value, "Content", "csharp"); // @@clientName(KeyVault.Setting.type, "SettingType", "csharp"); // @@clientName(KeyVault.SettingTypeEnum, "KeyVaultSettingType", "csharp"); // @@clientName(KeyVault.Permission, "KeyVaultPermission", "csharp"); From df7661c0fff094bb9b1873c6973e269278923fe1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonathan=20C=C3=A1rdenas?= Date: Wed, 22 Jan 2025 10:45:37 -0800 Subject: [PATCH 04/13] Uncomment access decorators --- .../Security.KeyVault.Administration/client.tsp | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/specification/keyvault/Security.KeyVault.Administration/client.tsp b/specification/keyvault/Security.KeyVault.Administration/client.tsp index 3cec123f7b38..1cd9cbc13171 100644 --- a/specification/keyvault/Security.KeyVault.Administration/client.tsp +++ b/specification/keyvault/Security.KeyVault.Administration/client.tsp @@ -42,14 +42,14 @@ namespace ClientCustomizations; // @@clientName(KeyVault.DataAction, "KeyVaultDataAction", "csharp"); // @@clientName(KeyVault.RestoreOperation, "RestoreDetailsInternal", "csharp"); -// @@access(KeyVault.RoleAssignmentCreateParameters, Access.internal, "csharp"); -// @@access(KeyVault.RoleDefinitionCreateParameters, Access.internal, "csharp"); -// @@access(KeyVault.SASTokenParameter, Access.internal, "csharp"); -// @@access(KeyVault.SelectiveKeyRestoreOperationParameters, -// Access.internal, -// "csharp" -// ); -// @@access(KeyVault.RoleDefinitionProperties, Access.internal, "csharp"); +@@access(KeyVault.RoleAssignmentCreateParameters, Access.internal, "csharp"); +@@access(KeyVault.RoleDefinitionCreateParameters, Access.internal, "csharp"); +@@access(KeyVault.SASTokenParameter, Access.internal, "csharp"); +@@access(KeyVault.SelectiveKeyRestoreOperationParameters, + Access.internal, + "csharp" +); +@@access(KeyVault.RoleDefinitionProperties, Access.internal, "csharp"); // @@clientName(KeyVault.FullBackupOperation.azureStorageBlobContainerUri, // "folderUri", From b99066372dd20d8c0b12e6e9757e8bbb352427b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonathan=20C=C3=A1rdenas?= Date: Wed, 22 Jan 2025 10:50:59 -0800 Subject: [PATCH 05/13] Make KeyVault internal --- .../client.tsp | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/specification/keyvault/Security.KeyVault.Administration/client.tsp b/specification/keyvault/Security.KeyVault.Administration/client.tsp index 1cd9cbc13171..5a5ba470c4ec 100644 --- a/specification/keyvault/Security.KeyVault.Administration/client.tsp +++ b/specification/keyvault/Security.KeyVault.Administration/client.tsp @@ -42,14 +42,17 @@ namespace ClientCustomizations; // @@clientName(KeyVault.DataAction, "KeyVaultDataAction", "csharp"); // @@clientName(KeyVault.RestoreOperation, "RestoreDetailsInternal", "csharp"); -@@access(KeyVault.RoleAssignmentCreateParameters, Access.internal, "csharp"); -@@access(KeyVault.RoleDefinitionCreateParameters, Access.internal, "csharp"); -@@access(KeyVault.SASTokenParameter, Access.internal, "csharp"); -@@access(KeyVault.SelectiveKeyRestoreOperationParameters, - Access.internal, - "csharp" -); -@@access(KeyVault.RoleDefinitionProperties, Access.internal, "csharp"); +// @@access(KeyVault.RoleAssignmentCreateParameters, Access.internal, "csharp"); +// @@access(KeyVault.RoleDefinitionCreateParameters, Access.internal, "csharp"); +// @@access(KeyVault.SASTokenParameter, Access.internal, "csharp"); +// @@access(KeyVault.SelectiveKeyRestoreOperationParameters, +// Access.internal, +// "csharp" +// ); +// @@access(KeyVault.RoleDefinitionProperties, Access.internal, "csharp"); + + +@@access(KeyVault, Access.internal, "csharp"); // @@clientName(KeyVault.FullBackupOperation.azureStorageBlobContainerUri, // "folderUri", From 8fb44e87b7c7ade404685e1dc8d51ef86a273c21 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonathan=20C=C3=A1rdenas?= Date: Thu, 23 Jan 2025 15:36:39 -0800 Subject: [PATCH 06/13] Omit unreachable types --- .../keyvault/Security.KeyVault.Administration/tspconfig.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/specification/keyvault/Security.KeyVault.Administration/tspconfig.yaml b/specification/keyvault/Security.KeyVault.Administration/tspconfig.yaml index 8cb89bd8fdec..65ac14c8bd9a 100644 --- a/specification/keyvault/Security.KeyVault.Administration/tspconfig.yaml +++ b/specification/keyvault/Security.KeyVault.Administration/tspconfig.yaml @@ -47,6 +47,7 @@ options: namespace: "Azure.Security.KeyVault.Administration" "output-path": "./src/Generated" flavor: azure + omit-unreachable-types: true "@azure-tools/typespec-ts": package-dir: "keyvault-admin" generateMetadata: true From 63049d57234a849f15f1d3c58bd09e88d07f5820 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonathan=20C=C3=A1rdenas?= Date: Thu, 23 Jan 2025 15:41:29 -0800 Subject: [PATCH 07/13] Move omit-unreachable-types to autorest options --- .../keyvault/Security.KeyVault.Administration/tspconfig.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/keyvault/Security.KeyVault.Administration/tspconfig.yaml b/specification/keyvault/Security.KeyVault.Administration/tspconfig.yaml index 65ac14c8bd9a..260846c6e5cf 100644 --- a/specification/keyvault/Security.KeyVault.Administration/tspconfig.yaml +++ b/specification/keyvault/Security.KeyVault.Administration/tspconfig.yaml @@ -21,6 +21,7 @@ options: azure-resource-provider-folder: "data-plane" emitter-output-dir: "{project-root}/.." output-file: "{azure-resource-provider-folder}/Microsoft.KeyVault/{version-status}/{version}/administration.json" + omit-unreachable-types: true # Uncomment this line and add "@azure-tools/typespec-python" to your package.json to generate Python code "@azure-tools/typespec-python": flavor: azure @@ -47,7 +48,6 @@ options: namespace: "Azure.Security.KeyVault.Administration" "output-path": "./src/Generated" flavor: azure - omit-unreachable-types: true "@azure-tools/typespec-ts": package-dir: "keyvault-admin" generateMetadata: true From fa0d77ef1a5e51871c352ebda335699b792c83ff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonathan=20C=C3=A1rdenas?= Date: Wed, 5 Feb 2025 14:20:12 -0800 Subject: [PATCH 08/13] use-model-reader-writer: true --- .../keyvault/Security.KeyVault.Administration/tspconfig.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/specification/keyvault/Security.KeyVault.Administration/tspconfig.yaml b/specification/keyvault/Security.KeyVault.Administration/tspconfig.yaml index 260846c6e5cf..072b59a3e065 100644 --- a/specification/keyvault/Security.KeyVault.Administration/tspconfig.yaml +++ b/specification/keyvault/Security.KeyVault.Administration/tspconfig.yaml @@ -48,6 +48,7 @@ options: namespace: "Azure.Security.KeyVault.Administration" "output-path": "./src/Generated" flavor: azure + use-model-reader-writer: true "@azure-tools/typespec-ts": package-dir: "keyvault-admin" generateMetadata: true From 0396fc3670b9e265173d2197dc5b97c00fec03d9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonathan=20C=C3=A1rdenas?= Date: Wed, 5 Feb 2025 14:23:40 -0800 Subject: [PATCH 09/13] use model reader writer false --- .../keyvault/Security.KeyVault.Administration/tspconfig.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/keyvault/Security.KeyVault.Administration/tspconfig.yaml b/specification/keyvault/Security.KeyVault.Administration/tspconfig.yaml index 072b59a3e065..f037d3d9aea1 100644 --- a/specification/keyvault/Security.KeyVault.Administration/tspconfig.yaml +++ b/specification/keyvault/Security.KeyVault.Administration/tspconfig.yaml @@ -48,7 +48,7 @@ options: namespace: "Azure.Security.KeyVault.Administration" "output-path": "./src/Generated" flavor: azure - use-model-reader-writer: true + use-model-reader-writer: false "@azure-tools/typespec-ts": package-dir: "keyvault-admin" generateMetadata: true From deb8e3f6e2e519c685ede124df5885e14588bb68 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonathan=20C=C3=A1rdenas?= Date: Wed, 5 Feb 2025 14:58:55 -0800 Subject: [PATCH 10/13] Rename Setting,Type to SettingType --- .../keyvault/Security.KeyVault.Administration/client.tsp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/specification/keyvault/Security.KeyVault.Administration/client.tsp b/specification/keyvault/Security.KeyVault.Administration/client.tsp index 5a5ba470c4ec..fefe8c16fe1f 100644 --- a/specification/keyvault/Security.KeyVault.Administration/client.tsp +++ b/specification/keyvault/Security.KeyVault.Administration/client.tsp @@ -16,6 +16,8 @@ namespace ClientCustomizations; @@clientName(KeyVault.SettingTypeEnum, "KeyVaultSettingType", "java"); //C# customizations +@@clientName(KeyVault.Setting.type, "SettingType", "csharp"); + //@@clientName(KeyVault.Setting, "KeyVaultSetting", "csharp"); @@clientName(KeyVault.Setting.value, "Content", "csharp"); // @@clientName(KeyVault.Setting.type, "SettingType", "csharp"); From 51ece0792e58093237589b842f68f2924e0eedca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonathan=20C=C3=A1rdenas?= Date: Wed, 5 Feb 2025 15:35:42 -0800 Subject: [PATCH 11/13] Cleanup csharp customizations --- .../client.tsp | 121 +----------------- 1 file changed, 1 insertion(+), 120 deletions(-) diff --git a/specification/keyvault/Security.KeyVault.Administration/client.tsp b/specification/keyvault/Security.KeyVault.Administration/client.tsp index fefe8c16fe1f..7ca02fbc5f7e 100644 --- a/specification/keyvault/Security.KeyVault.Administration/client.tsp +++ b/specification/keyvault/Security.KeyVault.Administration/client.tsp @@ -17,124 +17,5 @@ namespace ClientCustomizations; //C# customizations @@clientName(KeyVault.Setting.type, "SettingType", "csharp"); - -//@@clientName(KeyVault.Setting, "KeyVaultSetting", "csharp"); @@clientName(KeyVault.Setting.value, "Content", "csharp"); -// @@clientName(KeyVault.Setting.type, "SettingType", "csharp"); -// @@clientName(KeyVault.SettingTypeEnum, "KeyVaultSettingType", "csharp"); -// @@clientName(KeyVault.Permission, "KeyVaultPermission", "csharp"); -// @@clientName(KeyVault.RoleScope, "KeyVaultRoleScope", "csharp"); -// @@clientName(KeyVault.RoleType, "KeyVaultRoleType", "csharp"); -// @@clientName(KeyVault.RoleAssignment, "KeyVaultRoleAssignment", "csharp"); -// @@clientName(KeyVault.FullBackupOperation, -// "FullBackupDetailsInternal", -// "csharp" -// ); -// @@clientName(KeyVault.SettingsListResult, "GetSettingsResult", "csharp"); -// @@clientName(KeyVault.RoleAssignmentPropertiesWithScope, -// "KeyVaultRoleAssignmentProperties", -// "csharp" -// ); -// @@clientName(KeyVault.RoleDefinitionType, -// "KeyVaultRoleDefinitionType", -// "csharp" -// ); -// @@clientName(KeyVault.Permission, "KeyVaultPermission", "csharp"); -// @@clientName(Error, "KeyVaultServiceError", "csharp"); -// @@clientName(KeyVault.DataAction, "KeyVaultDataAction", "csharp"); -// @@clientName(KeyVault.RestoreOperation, "RestoreDetailsInternal", "csharp"); - -// @@access(KeyVault.RoleAssignmentCreateParameters, Access.internal, "csharp"); -// @@access(KeyVault.RoleDefinitionCreateParameters, Access.internal, "csharp"); -// @@access(KeyVault.SASTokenParameter, Access.internal, "csharp"); -// @@access(KeyVault.SelectiveKeyRestoreOperationParameters, -// Access.internal, -// "csharp" -// ); -// @@access(KeyVault.RoleDefinitionProperties, Access.internal, "csharp"); - - -@@access(KeyVault, Access.internal, "csharp"); - -// @@clientName(KeyVault.FullBackupOperation.azureStorageBlobContainerUri, -// "folderUri", -// "javascript" -// ); - -// @client( -// { -// name: "BackupRestoreRestClient", -// service: KeyVault, -// }, -// "csharp" -// ) -// interface BackupRestoreRestClient { -// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" -// fullBackup is KeyVault.fullBackup; -// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" -// #suppress "@azure-tools/typespec-azure-core/use-standard-names" "Operation name has already shipped" -// fullBackupStatus is KeyVault.fullBackupStatus; -// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" -// preFullBackup is KeyVault.preFullBackup; -// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" -// #suppress "@azure-tools/typespec-azure-core/use-standard-names" "Operation name has already shipped" -// restoreStatus is KeyVault.restoreStatus; -// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" -// preFullRestoreOperation is KeyVault.preFullRestoreOperation; -// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" -// fullRestoreOperation is KeyVault.fullRestoreOperation; -// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" -// selectiveKeyRestoreOperation is KeyVault.selectiveKeyRestoreOperation; -// } - -// @client( -// { -// name: "RoleAssignmentsRestClient", -// service: KeyVault, -// }, -// "csharp" -// ) -// interface RoleAssignmentsRestClient { -// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" -// delete is KeyVault.RoleAssignments.delete; -// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" -// create is KeyVault.RoleAssignments.create; -// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" -// get is KeyVault.RoleAssignments.get; -// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" -// listForScope is KeyVault.RoleAssignments.listForScope; -// } - -// @client( -// { -// name: "RoleDefinitionsRestClient", -// service: KeyVault, -// }, -// "csharp" -// ) -// interface RoleDefinitionsRestClient { -// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" -// delete is KeyVault.RoleDefinitions.delete; -// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" -// createOrUpdate is KeyVault.RoleDefinitions.createOrUpdate; -// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" -// get is KeyVault.RoleDefinitions.get; -// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" -// list is KeyVault.RoleDefinitions.list; -// } - -// @client( -// { -// name: "SettingsRestClient", -// service: KeyVault, -// }, -// "csharp" -// ) -// interface SettingsRestClient { -// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" -// updateSetting is KeyVault.updateSetting; -// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" -// getSetting is KeyVault.getSetting; -// #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops" -// getSettings is KeyVault.getSettings; -// } +@@access(KeyVault, Access.internal, "csharp"); \ No newline at end of file From 22bf0b2f2d9f9412784d79abc169789813902aa8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonathan=20C=C3=A1rdenas?= Date: Tue, 11 Feb 2025 15:30:51 -0800 Subject: [PATCH 12/13] format client.tsp --- .../keyvault/Security.KeyVault.Administration/client.tsp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/keyvault/Security.KeyVault.Administration/client.tsp b/specification/keyvault/Security.KeyVault.Administration/client.tsp index 7ca02fbc5f7e..6661777dc72a 100644 --- a/specification/keyvault/Security.KeyVault.Administration/client.tsp +++ b/specification/keyvault/Security.KeyVault.Administration/client.tsp @@ -18,4 +18,4 @@ namespace ClientCustomizations; //C# customizations @@clientName(KeyVault.Setting.type, "SettingType", "csharp"); @@clientName(KeyVault.Setting.value, "Content", "csharp"); -@@access(KeyVault, Access.internal, "csharp"); \ No newline at end of file +@@access(KeyVault, Access.internal, "csharp"); From e3ceb343be033be4e3407c48df2f1d6e00952ae4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonathan=20C=C3=A1rdenas?= Date: Tue, 11 Feb 2025 15:54:23 -0800 Subject: [PATCH 13/13] Remove omit-unreachable-types --- .../keyvault/Security.KeyVault.Administration/tspconfig.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/specification/keyvault/Security.KeyVault.Administration/tspconfig.yaml b/specification/keyvault/Security.KeyVault.Administration/tspconfig.yaml index f037d3d9aea1..9aee7ef0521c 100644 --- a/specification/keyvault/Security.KeyVault.Administration/tspconfig.yaml +++ b/specification/keyvault/Security.KeyVault.Administration/tspconfig.yaml @@ -21,7 +21,6 @@ options: azure-resource-provider-folder: "data-plane" emitter-output-dir: "{project-root}/.." output-file: "{azure-resource-provider-folder}/Microsoft.KeyVault/{version-status}/{version}/administration.json" - omit-unreachable-types: true # Uncomment this line and add "@azure-tools/typespec-python" to your package.json to generate Python code "@azure-tools/typespec-python": flavor: azure