Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nextTick workaround when Edge issue resolved #489

Closed
brettsam opened this issue Jul 12, 2016 · 3 comments
Closed

Remove nextTick workaround when Edge issue resolved #489

brettsam opened this issue Jul 12, 2016 · 3 comments
Labels
bug
Milestone
Backlog

Comments

@brettsam
Copy link
Member

PR #486 introduced a temp fix to set nextTick = setImmediate. This works around Edge issue tjanczuk/edge#325. When that issue is resolved, we need to remove the workaround.
@brettsam brettsam changed the title Remove nextTick hack when Edge issue resolved Remove nextTick workaround when Edge issue resolved Jul 12, 2016
@christopheranderson christopheranderson added this to the Next - Triaged milestone Aug 1, 2016
@christopheranderson
Copy link
Contributor

Impact: this might make some node modules not work properly until addressed if they use nextTick

@mathewc
Copy link
Member

mathewc commented Sep 19, 2016

The workaround we have in place for this no longer involves replacing nextTick. here is the latest: 0f32127. However when the Edge issue is fixed, as before, we should be able to revert this.

@fabiocav
Copy link
Member

We're no longer tracking this issue. Closing.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@mathewc @brettsam @christopheranderson @fabiocav