Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate build for minified versions #3855

Closed
surgupta-msft opened this issue Oct 1, 2024 · 1 comment
Closed

Separate build for minified versions #3855

surgupta-msft opened this issue Oct 1, 2024 · 1 comment
Assignees
Labels
area: engineering Engineering improvements enhancement

Comments

@surgupta-msft
Copy link
Contributor

surgupta-msft commented Oct 1, 2024

Description

Currently same coretools build publish different artifacts for visual studio (minified versions - link) and cli/vscode. We can improve the build process to separate out visual studio artifacts and use symbol approach as below. This will make overall code simpler. After this we can cleanup the logic in this PR for IsMinifiedVersion() - #3825

In C# -

#if MINVERSION    
    internal const bool MIN_VERSION = true;
#else   
    internal const bool MIN_VERSION = false;
#endif

In csproj -

<PropertyGroup>
    <DefineConstants Condition="'$(MinVersion)' = 'true'">$(DefineConstants);MINVERSION</DefineConstants>
</PropertyGroup>

We also need overall engineering improvements in the build process here to change from dotnet build orchestration to msbuild

@surgupta-msft
Copy link
Contributor Author

Closing this as we will be refactoring the code here soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: engineering Engineering improvements enhancement
Projects
None yet
Development

No branches or pull requests

2 participants