Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build flow for minified versions to include a configuration file #3854

Closed
surgupta-msft opened this issue Oct 1, 2024 · 0 comments · Fixed by #3825
Closed

Update build flow for minified versions to include a configuration file #3854

surgupta-msft opened this issue Oct 1, 2024 · 0 comments · Fixed by #3825

Comments

@surgupta-msft
Copy link
Contributor

Description

Follow-up item for changes in this PR - #3825

The PR introduces a new config file artifactsconfig.json which may or may not be present in coretools. Any changes in coretools that should go to visual studio artifacts and not to cli/vscode can call this check - Utilites.IsMinifiedVersion() = true. In BuildSteps.cs, we create minified version of coretools for Visual Studio case - link.

For now, artifactsconfig.json has only below content -

{
    "minifiedVersion" : true
}

We need to update build flow so that minified versions will have this config file and make sure that artifacts are being created correctly for visual studio and cli use cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants