Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Documentation contains invalid hook "preinit" #1550

Closed
1 task done
lechnerc77 opened this issue Feb 12, 2023 · 3 comments
Closed
1 task done

[Issue] Documentation contains invalid hook "preinit" #1550

lechnerc77 opened this issue Feb 12, 2023 · 3 comments
Assignees
Labels
customer-reported identify a customer issue documentation Improvements or additions to documentation extensibility question

Comments

@lechnerc77
Copy link
Contributor

lechnerc77 commented Feb 12, 2023

Output from azd version

azd version 0.6.0-beta.2 (commit c4a201e)

Output from az version

n/a - not relevant for my scenario

Describe the bug

The documentations and the announcement blog post for azd version 0.6.0-beta.1 contain a code snippet that contains the hook definition for a preinit event (link).

This event is not foreseen in the JSON schema of the azure.yaml as a vlid entry.

I assume that this event should not be part of the flow.

To Reproduce

Define a azure.yaml and specify a preinit hook.

VSCode will highlight an issue due to validation.
Executing an azd init with the file does not show any effect, it does not seem that the hook gets picked up.

Expected behavior

Not sure: either the documentation needs to be adjusted or the event is indeed missing in the azure.yaml JSON schema as well as in the azd implementation.

Environment

n/a

Additional context

n/a

@ghost ghost added needs-triage For new issues customer-reported identify a customer issue question labels Feb 12, 2023
@rajeshkamal5050 rajeshkamal5050 added documentation Improvements or additions to documentation extensibility labels Feb 12, 2023
@rajeshkamal5050 rajeshkamal5050 added this to the Mar 8 - Release 0.7 milestone Feb 12, 2023
@ghost ghost removed the needs-triage For new issues label Feb 12, 2023
@rajeshkamal5050
Copy link
Contributor

@gkulin @wbreza can we get the docs fixed?

@gkulin
Copy link
Collaborator

gkulin commented Feb 14, 2023

will work on a pr now

@lechnerc77 lechnerc77 changed the title [Issue] Documentation contains invlaid hook "preinit" [Issue] Documentation contains invalid hook "preinit" Feb 16, 2023
@savannahostrowski
Copy link

Completed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported identify a customer issue documentation Improvements or additions to documentation extensibility question
Projects
None yet
Development

No branches or pull requests

5 participants