Skip to content

Commit f0b6a94

Browse files
committed
Addressing Comments
1 parent 31ed0d3 commit f0b6a94

File tree

5 files changed

+7
-11
lines changed

5 files changed

+7
-11
lines changed

.pipelines/pipeline.yaml

+5-6
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ stages:
327327
vmSize: Standard_B2ms
328328
k8sVersion: ""
329329
windowsOsSku: ""
330-
dependsOn: 'containerize'
330+
dependsOn: 'validate1'
331331

332332
- template: singletenancy/cilium-overlay/cilium-overlay-e2e-job-template.yaml
333333
parameters:
@@ -340,7 +340,7 @@ stages:
340340
vmSize: Standard_B2ms
341341
k8sVersion: ""
342342
windowsOsSku: ""
343-
dependsOn: 'containerize'
343+
dependsOn: 'validate1'
344344

345345
- template: singletenancy/aks-swift/e2e-job-template.yaml
346346
parameters:
@@ -353,8 +353,7 @@ stages:
353353
vmSize: Standard_B2s
354354
k8sVersion: ""
355355
windowsOsSku: ""
356-
osSku: "Ubuntu"
357-
dependsOn: 'containerize'
356+
dependsOn: 'validate1'
358357

359358
- template: singletenancy/aks/e2e-job-template.yaml
360359
parameters:
@@ -367,7 +366,7 @@ stages:
367366
vmSize: Standard_B2s
368367
k8sVersion: 1.25
369368
scaleup: 100
370-
dependsOn: 'containerize'
369+
dependsOn: 'validate1'
371370

372371
- template: singletenancy/aks/e2e-job-template.yaml
373372
parameters:
@@ -381,7 +380,7 @@ stages:
381380
windowsOsSku: 'Windows2022'
382381
os_version: 'ltsc2022'
383382
scaleup: 50
384-
dependsOn: 'containerize'
383+
dependsOn: 'validate1'
385384

386385
- stage: validate2
387386
displayName: Validate Tags

.pipelines/singletenancy/aks-swift/e2e-step-template.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ parameters:
22
name: ""
33
testDropgz: ""
44
clusterName: ""
5-
osSku: ""
65

76
steps:
87
- bash: |

.pipelines/singletenancy/aks/e2e-cluster-template.yaml

-2
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ stages:
2727
inlineScript: |
2828
set -e
2929
mkdir -p ~/.kube/
30-
# echo "Create AKS cluster"
31-
# echo "parameters ${{ parameters.windowsOsSku }}"
3230
make -C ./hack/aks azcfg AZCLI=az REGION=$(REGION_AKS_CLUSTER_TEST)
3331
make -C ./hack/aks ${{ parameters.clusterType }} AZCLI=az REGION=$(REGION_AKS_CLUSTER_TEST) SUB=$(SUB_AZURE_NETWORK_AGENT_TEST) CLUSTER=${{ parameters.clusterName }}-$(make revision) K8S_VER=${{ parameters.k8sVersion }} VM_SIZE=${{ parameters.vmSize }} WINDOWS_OS_SKU=${{ parameters.windowsOsSku }} WINDOWS_VM_SKU=${{ parameters.vmSize }} WINDOWS_USERNAME=${WINDOWS_USERNAME} WINDOWS_PASSWORD=${WINDOWS_PASSWORD}
3432
echo "Cluster successfully created"

.pipelines/singletenancy/cilium-overlay/cilium-overlay-e2e-step-template.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ steps:
149149
- script: |
150150
echo "validate pod IP assignment and check systemd-networkd restart"
151151
kubectl get pod -owide -A
152-
# Deleting echo-external-node deployment until version matches TODO. Upstream TODO has change. - Replace todo with vipul work/PR in upstream
152+
# Deleting echo-external-node deployment until cilium version matches TODO. https://github.com/cilium/cilium-cli/issues/67 is addressing the change.
153153
# Saves 17 minutes
154154
kubectl delete deploy -n cilium-test echo-external-node
155155
if [ "$CILIUM_VERSION_TAG" = "cilium-nightly-pipeline" ]; then

.pipelines/singletenancy/cilium/cilium-e2e-step-template.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ steps:
133133
- script: |
134134
echo "validate pod IP assignment and check systemd-networkd restart"
135135
kubectl get pod -owide -A
136-
# Deleting echo-external-node deployment until version matches TODO. Upstream TODO has change. - Replace todo with vipul work/PR in upstream
136+
# Deleting echo-external-node deployment until cilium version matches TODO. https://github.com/cilium/cilium-cli/issues/67 is addressing the change.
137137
# Saves 17 minutes
138138
kubectl delete deploy -n cilium-test echo-external-node
139139
make test-validate-state

0 commit comments

Comments
 (0)