Skip to content

Commit b7fd6b5

Browse files
committed
change the structure of the zap log
1 parent 5db066e commit b7fd6b5

File tree

9 files changed

+17
-20
lines changed

9 files changed

+17
-20
lines changed

cni/api/api.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,12 @@ import (
66
"os"
77

88
"github.com/Azure/azure-container-networking/cni/log"
9-
"github.com/Azure/azure-container-networking/zaplog"
109
"go.uber.org/zap"
1110
)
1211

1312
var (
1413
LoggerVnetName = "azure-vnet"
15-
logger = zaplog.InitLog(log.LoggerVnetCfg).With(zap.String("component", "cni"))
14+
logger = log.InitZapLogCNI(log.LoggerVnetCfg).With(zap.String("component", "cni"))
1615
)
1716

1817
type PodNetworkInterfaceInfo struct {

cni/ipam/ipam.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import (
1313
"github.com/Azure/azure-container-networking/common"
1414
"github.com/Azure/azure-container-networking/ipam"
1515
"github.com/Azure/azure-container-networking/platform"
16-
"github.com/Azure/azure-container-networking/zaplog"
1716
cniSkel "github.com/containernetworking/cni/pkg/skel"
1817
cniTypes "github.com/containernetworking/cni/pkg/types"
1918
cniTypesCurr "github.com/containernetworking/cni/pkg/types/100"
@@ -24,7 +23,7 @@ const ipamV6 = "azure-vnet-ipamv6"
2423

2524
var (
2625
LoggerVnetName = "azure-vnet-ipam"
27-
logger = zaplog.InitLog(log.LoggerIpamCfg).With(zap.String("component", "cni"))
26+
logger = log.InitZapLogCNI(log.LoggerIpamCfg).With(zap.String("component", "cni"))
2827
)
2928

3029
var ipv4DefaultRouteDstPrefix = net.IPNet{

cni/log/logger.go

+8-4
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package log
22

33
import (
4-
"github.com/Azure/azure-container-networking/log"
54
"github.com/Azure/azure-container-networking/zaplog"
5+
"go.uber.org/zap"
66
"go.uber.org/zap/zapcore"
77
)
88

@@ -20,24 +20,28 @@ var (
2020

2121
var LoggerVnetCfg = &zaplog.Config{
2222
Level: zapcore.DebugLevel,
23-
LogPath: log.LogPath + "azure-vnet.log",
23+
LogPath: LogPath + "azure-vnet.log",
2424
MaxSizeInMB: maxLogFileSizeInMb,
2525
MaxBackups: maxLogFileCount,
2626
Name: LoggerVnetName,
2727
}
2828

2929
var LoggerIpamCfg = &zaplog.Config{
3030
Level: zapcore.DebugLevel,
31-
LogPath: log.LogPath + "azure-ipam.log",
31+
LogPath: LogPath + "azure-ipam.log",
3232
MaxSizeInMB: maxLogFileSizeInMb,
3333
MaxBackups: maxLogFileCount,
3434
Name: LoggerIpamName,
3535
}
3636

3737
var LoggerTelemetryCfg = &zaplog.Config{
3838
Level: zapcore.DebugLevel,
39-
LogPath: log.LogPath + "azure-vnet-telemetry.log",
39+
LogPath: LogPath + "azure-vnet-telemetry.log",
4040
MaxSizeInMB: maxLogFileSizeInMb,
4141
MaxBackups: maxLogFileCount,
4242
Name: LoggerTelemetryName,
4343
}
44+
45+
func InitZapLogCNI(zapLogConfig *zaplog.Config) *zap.Logger {
46+
return zaplog.InitZapLog(zapLogConfig)
47+
}

cni/log/logger_mock.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
package log
22

33
import (
4-
"github.com/Azure/azure-container-networking/zaplog"
54
"go.uber.org/zap"
65
)
76

87
func InitializeMock() {
9-
zaplog.InitLog(LoggerVnetCfg).With(zap.String("component", "cni"))
8+
InitZapLogCNI(LoggerVnetCfg).With(zap.String("component", "cni"))
109
}

cni/network/invoker_azure.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import (
1313
"github.com/Azure/azure-container-networking/ipam"
1414
"github.com/Azure/azure-container-networking/network"
1515
"github.com/Azure/azure-container-networking/platform"
16-
"github.com/Azure/azure-container-networking/zaplog"
1716
cniSkel "github.com/containernetworking/cni/pkg/skel"
1817
cniTypes "github.com/containernetworking/cni/pkg/types"
1918
cniTypesCurr "github.com/containernetworking/cni/pkg/types/100"
@@ -22,7 +21,7 @@ import (
2221

2322
var (
2423
LoggerVnetName = "azure-vnet"
25-
logger = zaplog.InitLog(log.LoggerVnetCfg).With(zap.String("component", "cni"))
24+
logger = log.InitZapLogCNI(log.LoggerVnetCfg).With(zap.String("component", "cni"))
2625
)
2726

2827
const (

cni/network/plugin/main.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import (
2121
"github.com/Azure/azure-container-networking/platform"
2222
"github.com/Azure/azure-container-networking/store"
2323
"github.com/Azure/azure-container-networking/telemetry"
24-
"github.com/Azure/azure-container-networking/zaplog"
2524
"github.com/containernetworking/cni/pkg/skel"
2625
cniTypes "github.com/containernetworking/cni/pkg/types"
2726
"github.com/pkg/errors"
@@ -42,7 +41,7 @@ var version string
4241

4342
var (
4443
LoggerVnetName = name
45-
logger = zaplog.InitLog(log.LoggerVnetCfg).With(zap.String("component", "cni"))
44+
logger = log.InitZapLogCNI(log.LoggerVnetCfg).With(zap.String("component", "cni"))
4645
)
4746

4847
// Command line arguments for CNI plugin.

cni/plugin.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import (
1515
"github.com/Azure/azure-container-networking/platform"
1616
"github.com/Azure/azure-container-networking/processlock"
1717
"github.com/Azure/azure-container-networking/store"
18-
"github.com/Azure/azure-container-networking/zaplog"
1918
cniInvoke "github.com/containernetworking/cni/pkg/invoke"
2019
cniSkel "github.com/containernetworking/cni/pkg/skel"
2120
cniTypes "github.com/containernetworking/cni/pkg/types"
@@ -27,7 +26,7 @@ import (
2726

2827
var (
2928
LoggerVnetName = "azure-vnet"
30-
logger = zaplog.InitLog(log.LoggerVnetCfg).With(zap.String("component", "cni"))
29+
logger = log.InitZapLogCNI(log.LoggerVnetCfg).With(zap.String("component", "cni"))
3130
)
3231

3332
var errEmptyContent = errors.New("read content is zero bytes")

cni/telemetry/service/telemetrymain.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import (
1313
"github.com/Azure/azure-container-networking/cni/log"
1414
acn "github.com/Azure/azure-container-networking/common"
1515
"github.com/Azure/azure-container-networking/telemetry"
16-
"github.com/Azure/azure-container-networking/zaplog"
1716
"go.uber.org/zap"
1817
"go.uber.org/zap/zapcore"
1918
)
@@ -119,7 +118,7 @@ func main() {
119118

120119
log.LoggerTelemetryCfg.Level = logLevel
121120
log.LoggerTelemetryCfg.Name = azureVnetTelemetry
122-
logger := zaplog.InitLog(log.LoggerVnetCfg).With(zap.String("component", "cni"))
121+
logger := log.InitZapLogCNI(log.LoggerTelemetryCfg).With(zap.String("component", "cni"))
123122

124123
logger.Info("Telemetry invocation info", zap.Any("arguments", os.Args))
125124

zaplog/zaplog.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import (
88
"gopkg.in/natefinch/lumberjack.v2"
99
)
1010

11-
var ZapDefaultLogger = InitLog(&Config{})
11+
var ZapDefaultLogger = InitZapLog(&Config{})
1212

1313
type Config struct {
1414
Level zapcore.Level
@@ -18,7 +18,7 @@ type Config struct {
1818
Name string
1919
}
2020

21-
func InitLog(cfg *Config) *zap.Logger {
21+
func InitZapLog(cfg *Config) *zap.Logger {
2222
logFileWriter := zapcore.AddSync(&lumberjack.Logger{
2323
Filename: cfg.LogPath,
2424
MaxSize: cfg.MaxSizeInMB,

0 commit comments

Comments
 (0)