fix: lint findings

Author: estebancams

cni/ipam/ipam_test.go

@@ -99,7 +99,6 @@ var (
 		arg = &cniSkel.CmdArgs{}
 
 		log.InitializeMock()
-
 	})
 
 	_ = AfterSuite(func() {

cni/ipam/plugin/main.go

@@ -37,7 +37,7 @@ func main() {
 		MaxBackups:  maxLogFileCount,
 		Name:        name,
 	}
-	log.Initialize(loggerCfg, ctx)
+	log.Initialize(ctx, loggerCfg)
 
 	ipamPlugin, err := ipam.NewPlugin(name, &config)
 	if err != nil {

cni/ipam/pluginv6/main.go

@@ -37,7 +37,7 @@ func main() {
 		MaxBackups:  maxLogFileCount,
 		Name:        name,
 	}
-	log.Initialize(loggerCfg, ctx)
+	log.Initialize(ctx, loggerCfg)
 
 	ipamPlugin, err := ipam.NewPlugin(name, &config)
 	if err != nil {

cni/log/logger.go

@@ -2,6 +2,7 @@ package log
 
 import (
 	"context"
+	"fmt"
 
 	"go.uber.org/zap"
 	"go.uber.org/zap/zapcore"
@@ -19,12 +20,15 @@ type Config struct {
 var Logger *zap.Logger
 
 // Initializes a Zap logger and returns a cleanup function so logger can be cleaned up from caller
-func Initialize(cfg *Config, ctx context.Context) {
+func Initialize(ctx context.Context, cfg *Config) {
 	Logger = newFileLogger(cfg)
 
 	go func() {
 		<-ctx.Done()
-		Logger.Sync()
+		err := Logger.Sync()
+		if err != nil {
+			fmt.Println("failed to sync logger")
+		}
 	}()
 }
 

cni/network/plugin/main.go

@@ -302,7 +302,7 @@ func main() {
 		MaxBackups:  maxLogFileCount,
 		Name:        name,
 	}
-	log.Initialize(loggerCfg, ctx)
+	log.Initialize(ctx, loggerCfg)
 
 	if rootExecute() != nil {
 		os.Exit(1)

cni/telemetry/service/telemetrymain.go

@@ -124,7 +124,7 @@ func main() {
 		MaxBackups:  maxLogFileCount,
 		Name:        azureVnetTelemetry,
 	}
-	log.Initialize(loggerCfg, ctx)
+	log.Initialize(ctx, loggerCfg)
 
 	log.Logger.Info("Telemetry invocation info", zap.Any("arguments", os.Args))