Skip to content

Commit 7c8ebb7

Browse files
committed
comment fix
1 parent 895baa1 commit 7c8ebb7

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

cni/plugin.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ import (
2525
)
2626

2727
var logger = log.CNILogger.With(zap.String("component", "cni-plugin"))
28+
var storeLogger = log.CNILogger.With(zap.String("component", "store"))
2829

2930
var errEmptyContent = errors.New("read content is zero bytes")
3031

@@ -188,7 +189,7 @@ func (plugin *Plugin) InitializeKeyValueStore(config *common.PluginConfig) error
188189
return errors.Wrap(err, "error creating new filelock")
189190
}
190191

191-
plugin.Store, err = store.NewJsonFileStore(platform.CNIRuntimePath+plugin.Name+".json", lockclient, logger)
192+
plugin.Store, err = store.NewJsonFileStore(platform.CNIRuntimePath+plugin.Name+".json", lockclient, storeLogger)
192193
if err != nil {
193194
logger.Error("Failed to create store", zap.Error(err))
194195
return err

store/json.go

+5-8
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,13 @@ import (
1212
"sync"
1313
"time"
1414

15-
zapLog "github.com/Azure/azure-container-networking/cni/log"
1615
"github.com/Azure/azure-container-networking/log"
1716
"github.com/Azure/azure-container-networking/platform"
1817
"github.com/Azure/azure-container-networking/processlock"
1918
"github.com/pkg/errors"
2019
"go.uber.org/zap"
2120
)
2221

23-
var logger = zapLog.CNILogger.With(zap.String("component", "store"))
24-
2522
const (
2623
// LockExtension - Extension added to the file name for lock.
2724
LockExtension = ".lock"
@@ -90,7 +87,7 @@ func (kvs *jsonFileStore) Read(key string, value interface{}) error {
9087

9188
if len(b) == 0 {
9289
if kvs.logger != nil {
93-
logger.Info("Unable to read empty file", zap.String("fileName", kvs.fileName))
90+
kvs.logger.Info("Unable to read empty file", zap.String("fileName", kvs.fileName))
9491
} else {
9592
log.Printf("Unable to read file %s, was empty", kvs.fileName)
9693
}
@@ -196,7 +193,7 @@ func (kvs *jsonFileStore) Lock(timeout time.Duration) error {
196193
status := make(chan error)
197194

198195
if kvs.logger != nil {
199-
logger.Info("Acquiring process lock")
196+
kvs.logger.Info("Acquiring process lock")
200197
} else {
201198
log.Printf("Acquiring process lock")
202199
}
@@ -215,7 +212,7 @@ func (kvs *jsonFileStore) Lock(timeout time.Duration) error {
215212
}
216213

217214
if kvs.logger != nil {
218-
logger.Info("Acquired process lock with timeout value of", zap.Any("timeout", timeout))
215+
kvs.logger.Info("Acquired process lock with timeout value of", zap.Any("timeout", timeout))
219216
} else {
220217
log.Printf("Acquired process lock with timeout value of %v", timeout)
221218
}
@@ -234,7 +231,7 @@ func (kvs *jsonFileStore) Unlock() error {
234231
}
235232

236233
if kvs.logger != nil {
237-
logger.Info("Released process lock")
234+
kvs.logger.Info("Released process lock")
238235
} else {
239236
log.Printf("Released process lock")
240237
}
@@ -250,7 +247,7 @@ func (kvs *jsonFileStore) GetModificationTime() (time.Time, error) {
250247
info, err := os.Stat(kvs.fileName)
251248
if err != nil {
252249
if kvs.logger != nil {
253-
logger.Info("os.stat() for file", zap.String("fileName", kvs.fileName), zap.Error(err))
250+
kvs.logger.Info("os.stat() for file", zap.String("fileName", kvs.fileName), zap.Error(err))
254251
} else {
255252
log.Printf("os.stat() for file %v failed: %v", kvs.fileName, err)
256253
}

0 commit comments

Comments
 (0)