Skip to content

Commit 6a191ad

Browse files
huntergregoryrayaisaiah
authored andcommitted
resolved merge conflicts for init telemetry before dataplane
1 parent a7904db commit 6a191ad

File tree

2 files changed

+21
-6
lines changed

2 files changed

+21
-6
lines changed

kubernetes

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Subproject commit b11972a9c94c8877add6f536aff1c6f45a933303

npm/cmd/start.go

+20-6
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,24 @@ func start(config npmconfig.Config, flags npmconfig.Flags) error {
116116
resyncPeriod := time.Duration(float64(minResyncPeriod.Nanoseconds()) * factor)
117117
klog.Infof("Resync period for NPM pod is set to %d.", int(resyncPeriod/time.Minute))
118118
factory := informers.NewSharedInformerFactory(clientset, resyncPeriod)
119+
podFactory := factory // // Separate podFactory for different versions in npm and npm lite.
120+
// npm-lite -> daemon set will listen to pods only in its own node
121+
if config.Toggles.EnableNPMLite {
122+
podFactory = informers.NewSharedInformerFactoryWithOptions(
123+
clientset,
124+
resyncPeriod,
125+
informers.WithTweakListOptions(func(options *metav1.ListOptions) {
126+
// Use field selector to filter pods based on their assigned node
127+
klog.Infof("NPM agent is listening to pods only under its node")
128+
options.FieldSelector = "spec.nodeName=" + models.GetNodeName()
129+
}),
130+
)
131+
}
119132

120-
k8sServerVersion := k8sServerVersion(clientset)
133+
err = metrics.CreateTelemetryHandle(config.NPMVersion(), version, npm.GetAIMetadata())
134+
if err != nil {
135+
klog.Infof("CreateTelemetryHandle failed with error %v. AITelemetry is not initialized.", err)
136+
}
121137

122138
var dp dataplane.GenericDataplane
123139
stopChannel := wait.NeverStop
@@ -181,11 +197,9 @@ func start(config npmconfig.Config, flags npmconfig.Flags) error {
181197
}
182198
dp.RunPeriodicTasks()
183199
}
184-
npMgr := npm.NewNetworkPolicyManager(config, factory, dp, exec.New(), version, k8sServerVersion)
185-
err = metrics.CreateTelemetryHandle(config.NPMVersion(), version, npm.GetAIMetadata())
186-
if err != nil {
187-
klog.Infof("CreateTelemetryHandle failed with error %v. AITelemetry is not initialized.", err)
188-
}
200+
201+
k8sServerVersion := k8sServerVersion(clientset)
202+
npMgr := npm.NewNetworkPolicyManager(config, factory, podFactory, dp, exec.New(), version, k8sServerVersion)
189203

190204
go restserver.NPMRestServerListenAndServe(config, npMgr)
191205

0 commit comments

Comments
 (0)