Skip to content

Commit 545d134

Browse files
authored
cleanup redundant logs in cns savestate-file, createorUpdateNetworkCo… (#2442)
cleanup redundant logs in cns savestate-file, createorUpdateNetworkContainer
1 parent 2a024b8 commit 545d134

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

cns/restserver/api.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -783,10 +783,9 @@ func (service *HTTPRestService) getHomeAz(w http.ResponseWriter, r *http.Request
783783
}
784784

785785
func (service *HTTPRestService) createOrUpdateNetworkContainer(w http.ResponseWriter, r *http.Request) {
786-
logger.Printf("[Azure CNS] createOrUpdateNetworkContainer")
787-
788786
var req cns.CreateNetworkContainerRequest
789787
if err := service.Listener.Decode(w, r, &req); err != nil {
788+
logger.Errorf("[Azure CNS] could not decode request: %v", err)
790789
w.WriteHeader(http.StatusBadRequest)
791790
return
792791
}

cns/restserver/util.go

+3-7
Original file line numberDiff line numberDiff line change
@@ -49,21 +49,17 @@ func (service *HTTPRestService) removeNetworkInfo(networkName string) {
4949

5050
// saveState writes CNS state to persistent store.
5151
func (service *HTTPRestService) saveState() error {
52-
logger.Printf("[Azure CNS] saveState")
53-
5452
// Skip if a store is not provided.
5553
if service.store == nil {
56-
logger.Printf("[Azure CNS] store not initialized.")
54+
logger.Printf("[Azure CNS] store not initialized.")
5755
return nil
5856
}
5957

6058
// Update time stamp.
6159
service.state.TimeStamp = time.Now()
6260
err := service.store.Write(storeKey, &service.state)
63-
if err == nil {
64-
logger.Printf("[Azure CNS] State saved successfully.\n")
65-
} else {
66-
logger.Errorf("[Azure CNS] Failed to save state., err:%v\n", err)
61+
if err != nil {
62+
logger.Errorf("[Azure CNS] Failed to save state, err: %v", err)
6763
}
6864

6965
return err

0 commit comments

Comments
 (0)