perf: Store Lock timeout for CNI in Windows is increased to 1 minute. (#1924)

* fix: Store Lock timeout for CNI in Windows is increased to 1 minute.

* rollback the telemtry lock timeout to 10 sec.

Author: behzad-mir

aitelemetry/telemetrywrapper.go

@@ -116,9 +116,8 @@ func getMetadata(th *telemetryHandle) {
 		debugLog("[AppInsights] Error initializing kvs store: %v", err)
 		return
 	}
-
-	err = kvs.Lock(store.DefaultLockTimeout)
-	if err != nil {
+	// Acquire store lock.
+	if err = kvs.Lock(store.DefaultLockTimeout); err != nil {
 		log.Errorf("getMetadata: Not able to acquire lock:%v", err)
 		return
 	}

cni/plugin.go

@@ -8,6 +8,7 @@ import (
 	"fmt"
 	"os"
 	"runtime"
+	"time"
 
 	"github.com/Azure/azure-container-networking/common"
 	"github.com/Azure/azure-container-networking/log"
@@ -174,8 +175,12 @@ func (plugin *Plugin) InitializeKeyValueStore(config *common.PluginConfig) error
 		}
 	}
 
-	// Acquire store lock.
-	if err := plugin.Store.Lock(store.DefaultLockTimeout); err != nil {
+	// Acquire store lock. For windows 1m timeout is used while for Linux 10s timeout is assigned.
+	var lockTimeoutValue time.Duration = store.DefaultLockTimeout
+	if runtime.GOOS == "windows" {
+		lockTimeoutValue = store.DefaultLockTimeoutWindows
+	}
+	if err := plugin.Store.Lock(lockTimeoutValue); err != nil {
 		log.Printf("[cni] Failed to lock store: %v.", err)
 		return errors.Wrap(err, "error Acquiring store lock")
 	}

store/json.go

@@ -23,7 +23,8 @@ const (
 	LockExtension = ".lock"
 
 	// DefaultLockTimeout - lock timeout in milliseconds
-	DefaultLockTimeout = 10000 * time.Millisecond
+	DefaultLockTimeout        = 10000 * time.Millisecond
+	DefaultLockTimeoutWindows = 60000 * time.Millisecond
 )
 
 // jsonFileStore is an implementation of KeyValueStore using a local JSON file.
@@ -35,8 +36,9 @@ type jsonFileStore struct {
 	sync.Mutex
 }
 
-//nolint:revive // ignoring name change
 // NewJsonFileStore creates a new jsonFileStore object, accessed as a KeyValueStore.
+//
+//nolint:revive // ignoring name change
 func NewJsonFileStore(fileName string, lockclient processlock.Interface) (KeyValueStore, error) {
 	if fileName == "" {
 		return &jsonFileStore{}, errors.New("need to pass in a json file path")
@@ -195,7 +197,7 @@ func (kvs *jsonFileStore) Lock(timeout time.Duration) error {
 		return errors.Wrap(err, "processLock acquire error")
 	}
 
-	log.Printf("Acquired process lock")
+	log.Printf("Acquired process lock with timeout value of %v ", timeout)
 	return nil
 }