Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Best Practices] Tests should be self-contained ResourceGroupVCRTests #741

Closed
BurtBiel opened this issue Aug 24, 2016 · 1 comment
Closed
Assignees
Milestone

Comments

@BurtBiel
Copy link
Contributor

Today many (most?) of the VCR tests rely on manually created assets in order to run. This makes re-recording those tests much more difficult and makes a bulk re-recording of the test bed very time consuming. We should convert the tests that inherit directly from VCRTestBase to inherit from ResourceGroupVCRTestBase and make them create all the resources they need to run so re-recording is simple.

@tjprescott
Copy link
Member

The reason we have not done this across the board is because certain tests take a painfully long time to rerecord. I've added this guidance to the test authoring guide. Additionally, I'll add logic to each test that still needs to be converted so that the test to will fail during re-recording and prompt the developer to update the test structure to ResourceGroupVCRTestBase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants