-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LLC] Remove exception allocation from generated "Exists" method #1531
Comments
Update: Per discussion regarding calling the sync constructor where we're currently calling an async method:
Let's add the BufferContent() and BufferContentAsync() to Response, but wait to do this performance optimization. |
Hi @annelo-msft What's purpose of this issue? Is it to replace the current exception-generate method (clientDiagnostics.CreateRequestFailedException) to use RequestFailedException method. see following: |
Since this method is never used, let's not block GA on it. |
@annelo-msft Is the issue to replace the exception-generate method as above comment? Thanks |
To resolve this issue, we're pre-allocating an exception in the
default:
block of this switch statement.Once this issue has been completed, we will have all the pieces we need in place to wait to allocate the exception until
response.Value
is called, i.e. we believe we will have a public type calledOptionalResponse<T>
, and in its implementation of theValue
property, it can use the new constructor on RequestFailedException to create the exception.Depends on completion of: Azure/azure-sdk-for-net#23372
The text was updated successfully, but these errors were encountered: