-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PSRule] Run PSRule pre-flight validation on diff (PR check) #2150
Comments
Suggestion: Move to todo, but wait for #2425 completion. |
To run PSRule on changed files only ref https://github.com/microsoft/PSRule/blob/main/docs/concepts/PSRule/en-US/about_PSRule_Options.md#inputignoreunchangedpath
Ref also microsoft/PSRule#688 |
Enabling the option results anyway in a check on the whole repository. This may be due to the token replacement logic, actually changing the files we're supposed to ignore. This needs to be double checked. |
@eriqua Happy to take feedback on this if you can provide more details here or offline. |
CARML already has linter and broken links checks running when pull requests are open. The check is not blocking for the PR to be merged.
This issue is about extending the PR checks to also run PSRule pre-flight validation on diff (on the code changed by the PR).
As a first step, the suggestion is to keep the check non-blocking, allowing PRs to be merged even if they fail PSRule checks.
PR #2094 hosts a PoC running on the whole library. That should be updated to run only on diff.
Collect feedback on the PR and agree on possible missing implementation before merge.
The text was updated successfully, but these errors were encountered: