Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should CircuitSimulator be a base class? UltraCircuitSimulator? #676

Closed
codygunton opened this issue Aug 17, 2023 · 1 comment
Closed

Should CircuitSimulator be a base class? UltraCircuitSimulator? #676

codygunton opened this issue Aug 17, 2023 · 1 comment
Labels
circuit-simulator

Comments

@codygunton
Copy link
Collaborator

If there are any cases where the output of a stdlib function depends on the builder type (e.g., this would be the case with Pedersen), then I think eventually we want the circuit simulator should get the value of the Ultra thing. Should that be reflected in the naming? Will there be a need for other circuit simulators? This is related to #665
@codygunton codygunton changed the title Is the CircuitSimulator is a base class? UltraCircuitSimulator? Should CircuitSimulator be a base class? UltraCircuitSimulator? Aug 17, 2023
@codygunton codygunton mentioned this issue Aug 17, 2023
Merged
@codygunton
Copy link
Collaborator Author

Simulator is deprioritized.

@codygunton codygunton closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
circuit-simulator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@codygunton