Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate the new keystore in PXE #5627

Closed
Tracked by #5606
benesjan opened this issue Apr 9, 2024 · 0 comments · Fixed by #5731
Closed
Tracked by #5606

Integrate the new keystore in PXE #5627

benesjan opened this issue Apr 9, 2024 · 0 comments · Fixed by #5731
Assignees

Comments

@benesjan
Copy link
Contributor

benesjan commented Apr 9, 2024

Nuke the original key_store.ts and replace it with the new ones.

A few large changes will need to get done in this PR:

  1. Make PXE handle multiple key stores instead of just one --> originally we had 1 key store per PXE and the keystore could contain multiple accounts. I feel like having one account per keystore is nicer because that's how it's done in geth and it feels more natural.
  2. We will need to update oracles and APIs.
@github-project-automation github-project-automation bot moved this to Todo in A3 Apr 9, 2024
@benesjan benesjan self-assigned this Apr 12, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant